Skip to content

Callbacks need to handle more use-cases #395

Closed

Description

@johnhaley81

Callbacks currently expect a result to be returned every time. This isn't the case however with things such as git_status_foreac_ext.

Also, the code that is looking for a return value currently doesn't work and we'll need tbranyen/combyne#65 fixed before it works properly.

Additionally we'll need callbacks to handle having their own payloads instead of a universal payload that's sent to each callback. This is stopping the inclusion of many methods that use this pattern.

Activity

  1. self-assigned this
    on Feb 10, 2015
  2. added this to the 0.3.0 milestone on Feb 10, 2015
  3. johnhaley81 commented on Feb 11, 2015

    @johnhaley81
    CollaboratorAuthor

    This is a blocking issue for #355

  4. tbranyen commented on Feb 18, 2015

    @tbranyen
    Member

    Has this been resolved? Pretty sure I saw multiple payloads in the C++ last I looked.

  5. johnhaley81 commented on Feb 18, 2015

    @johnhaley81
    CollaboratorAuthor

    Not yet. The issue is with callbacks inside of a class function and not inside of a struct.

  6. johnhaley81 commented on Feb 18, 2015

    @johnhaley81
    CollaboratorAuthor

    However I was wrong about it being a blocking issue for #355 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions