Documentation broken #327

Activity

1. maxkorp commented on Dec 11, 2014

   

   maxkorp

   on Dec 11, 2014

   Collaborator

   More actions

   Interesting, what browser are you using? I can see it just fine on Chrome 39.0.2171.71 (OSX).
2. callumacrae commented on Dec 11, 2014

   

   callumacrae

   on Dec 11, 2014

   Author

   More actions

   Yeah, just noticed it's working fine in other browsers. I'm using 39.0.2171.71 (OSX).

   $(".api-content script").eq(1) returns undefined, which is what is causing the issue:

       var contentTemplate = combyne($(".api-content script").eq(1).html().trim());
   
3. maxkorp commented on Dec 11, 2014

   

   maxkorp

   on Dec 11, 2014

   Collaborator

   More actions

   Try an incognito window? I bet it's an extension, because it works fine on the exact same build for me.
4. callumacrae commented on Dec 11, 2014

   

   callumacrae

   on Dec 11, 2014

   Author

   More actions

   Ah, I forgot to disable my extensions when I tried it in incognito tab!

   It's this extension by @ttrefren breaking it: https://github.com/ttrefren/chrome-mpdebug. Not sure why.

   I've disabled that extension for now 😄
5. maxkorp commented on Dec 11, 2014

   

   maxkorp

   on Dec 11, 2014

   Collaborator

   More actions

   Weird. Oh well.
6. maxkorp

   closed this as completedon Dec 11, 2014
7. callumacrae commented on Dec 11, 2014

   

   callumacrae

   on Dec 11, 2014

   Author

   More actions

   Could mean that a selector in your documentation is brittle—have you had any issues like this before? I can take a look :)
8. maxkorp commented on Dec 11, 2014

   

   maxkorp

   on Dec 11, 2014

   Collaborator

   More actions

   Certainly possible. I'm not aware of having had any issues, but @tbranyen would know better. It would be awesome if you want to take a look, the docs have been needing love anyways. Heres the repo
   https://github.com/nodegit/nodegit.github.com
9. callumacrae commented on Dec 11, 2014

   

   callumacrae

   on Dec 11, 2014

   Author

   More actions

   👍, feel free to poke me every couple weeks or so because I'll probably forget
10. tbranyen commented on Dec 11, 2014

    

    tbranyen

    on Dec 11, 2014

    Member

    More actions

    I don't think it's our responsibility to guard against third party JavaScript breaking the application. If you have an extension breaking sites, I'd stop using it completely.
11. callumacrae commented on Dec 11, 2014

    

    callumacrae

    on Dec 11, 2014

    Author

    More actions

    It's not your responsibility, but it could be a sign that your code is breaking easily—e.g. if a load of plugins are using a similar pattern to chrome-mpdebug, your website could be broken by loads of extensions. That doesn't seem to be the case, though, so it's probably fine.