nodegit.Signature.now broken #306

Activity

1. tbranyen commented on Nov 28, 2014

   

   tbranyen

   on Nov 28, 2014

   Member

   More actions

   Might be because of the unix timestamp format it's expecting. We might be able to normalize this automatically in our lib convenience helpers.
2. johnhaley81 commented on Nov 28, 2014

   

   johnhaley81

   on Nov 28, 2014

   Collaborator

   More actions

   There are also ngit.Signature.now("Name", "my@email.com") and ngit.Signature.default() where the default one just returns what's in the git config for right now.
3. mcollina commented on Nov 28, 2014

   

   mcollina

   on Nov 28, 2014

   CollaboratorAuthor

   More actions

   ngit.Signature.now("Name", "my@email.com") is broken.
4. johnhaley81 commented on Nov 28, 2014

   

   johnhaley81

   on Nov 28, 2014

   Collaborator

   More actions

   Aaaaand that's what I get for responding to issues while sick =/

   You totally said that and I read something else.
5. maxkorp commented on Dec 1, 2014

   

   maxkorp

   on Dec 1, 2014

   Collaborator

   More actions

   We can definitely do this in a lib fix, but @johnhaley81 and I have been trying to find ways to wrap these kinds of helpers into the c++. I've got a clean plate today (as far as i remember, it's been almost a week, stop judging me), I can take a crack at it.
6. maxkorp commented on Dec 1, 2014

   

   maxkorp

   on Dec 1, 2014

   Collaborator

   More actions

   Hrm its actually an asynchrony issue, it seems. Digging a bit deeper now.
7. maxkorp commented on Dec 1, 2014

   

   maxkorp

   on Dec 1, 2014

   Collaborator

   More actions

   This should be fixed in master via #308
8. maxkorp

   closed this as completedon Dec 1, 2014
9. mcollina commented on Dec 2, 2014

   

   mcollina

   on Dec 2, 2014

   CollaboratorAuthor

   More actions

   Thanks! :)