Skip to content

libgit2 creation methods have name collisions with internal V8 functions #271

Closed

Description

@johnhaley81

The classes and structs that have creation methods in libgit2 (e.g. git_revwalk_new) will have their methods reduced to just New which is a name collision with an internal method. Either we rename this method or rename these methods to be something else. Maybe turn git_revwalk_new into Create or CreateRevwalk. The latter will retain backwards compatibility but is a little redundant.

Thoughts?

Activity

  1. maxkorp commented on Nov 12, 2014

    @maxkorp
    Collaborator

    I prefer Create, less redundant. Super easy to implement, I can drop this in pretty quick.

  2. self-assigned this
    on Nov 12, 2014
  3. johnhaley81 commented on Nov 12, 2014

    @johnhaley81
    CollaboratorAuthor

    Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions