rename create{X} to create

maxkorp · maxkorp · commit f2a18f5f6de2 · 2014-10-22T15:18:18.000-07:00
diff --git a/generate/setup.js b/generate/setup.js
@@ -114,6 +114,7 @@ fileNames.forEach(function(fileName, index) {
     }
 
     file.freeFunctionName = "git_" + fileName + "_free";
+    file.createFunctionName = "git_" + fileName + "_create";
   }
 
   // TODO Obsolete this.
@@ -136,12 +137,14 @@ fileNames.forEach(function(fileName, index) {
     return fnName === initFnName;
   });
 
-  // Doesn't actually exist.
+  // Free function doesn't actually exist.
   if (cFile.functions.indexOf(file.freeFunctionName) === -1) {
     delete file.freeFunctionName;
   }
 
-
+  if (cFile.functions.indexOf(file.createFunctionName) === -1) {
+    delete file.createFunctionName;
+  }
   var legacyFile = {};
 
   if (file.jsClassName.indexOf("Git") === 0) {
@@ -394,6 +397,12 @@ fileNames.forEach(function(fileName, index) {
     }
   });
 
+  if (file.createFunctionName) {
+    file.cppCreateFunctionName = typeMap[file.createFunctionName].cpp;
+    file.jsCreateFunctionName = typeMap[file.createFunctionName].js;
+    delete file.createFunctionName;
+  }
+
   files.push(file);
 });
 
diff --git a/generate/templates/class_content.cc b/generate/templates/class_content.cc
@@ -63,7 +63,11 @@ NAN_METHOD({{ cppClassName }}::New) {
   NanScope();
 
   if (args.Length() == 0 || !args[0]->IsExternal()) {
-    return NanThrowError("{{ cType }} is required.");
+    {%if createFunctionName%}
+    return NanThrowError("A new {{ cppClassName }} cannot be instantiated. Use {{ jsCreateFunctionName }} instead.");
+    {%else%}
+    return NanThrowError("A new {{ cppClassName }} cannot be instantiated.");
+    {%endif%}
   }
 
   {{ cppClassName }}* object = new {{ cppClassName }}(static_cast<{{ cType }} *>(Handle<External>::Cast(args[0])->Value()), args[1]->BooleanValue());
diff --git a/test/tests/commit.js b/test/tests/commit.js
@@ -91,18 +91,18 @@ describe("Commit", function() {
     history.on("commit", function(commit) {
       historyCount++;
     });
-    
+
     history.on("end", function(commits) {
       assert.equal(historyCount, expectedHistoryCount);
       assert.equal(commits.length, expectedHistoryCount);
 
       done();
     });
-    
+
     history.on("error", function(err) {
       assert.ok(false);
     });
-    
+
     history.start();
   });
 
@@ -143,7 +143,7 @@ describe("Commit", function() {
       treeWalker.on("error", function() {
         assert.ok(false);
       });
-      
+
       treeWalker.on("end", function(entries) {
         assert.equal(commitTreeEntryCount, expectedCommitTreeEntryCount);
         done();
