Skip to content

Commit d8494e2

Browse files
committed
Fix memory leak in unit tests
1 parent a1506cb commit d8494e2

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

test/tests/filter.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,6 @@ describe("Filter", function() {
571571

572572
it("applies the filters for a path on demand", function() {
573573
var test = this;
574-
var list;
575574

576575
return Registry.register(filterName, {
577576
apply: function(to, from, source) {
@@ -601,8 +600,7 @@ describe("Filter", function() {
601600
NodeGit.Filter.FLAG.DEFAULT
602601
);
603602
})
604-
.then(function(_list) {
605-
list = _list;
603+
.then(function(list) {
606604
return list.applyToFile(test.repository, "README.md");
607605
})
608606
.then(function(content) {
@@ -612,7 +610,6 @@ describe("Filter", function() {
612610

613611
it("applies the filters to a buffer on demand", function() {
614612
var test = this;
615-
var list;
616613

617614
return Registry.register(filterName, {
618615
apply: function(to, from, source) {
@@ -642,8 +639,7 @@ describe("Filter", function() {
642639
NodeGit.Filter.FLAG.DEFAULT
643640
);
644641
})
645-
.then(function(_list) {
646-
list = _list;
642+
.then(function(list) {
647643
/* jshint ignore:start */
648644
return list.applyToData(new String("garbo garbo garbo garbo"));
649645
/* jshint ignore:end */
@@ -704,6 +700,7 @@ describe("Filter", function() {
704700
})
705701
.then(function(content) {
706702
assert.equal(content, message);
703+
list = null;
707704
});
708705
});
709706
});

0 commit comments

Comments
 (0)