Shallow clone before mutating the options object

tbranyen · tbranyen · commit c31ea4e3e5f2 · 2015-04-20T16:31:16.000-04:00
diff --git a/lib/clone.js b/lib/clone.js
@@ -1,4 +1,5 @@
 var NodeGit = require("../");
+var shallowClone = require("./utils/shallow_clone");
 var normalizeOptions = NodeGit.Utils.normalizeOptions;
 
 var Clone = NodeGit.Clone;
@@ -17,7 +18,9 @@ Clone.clone = function(url, local_path, options) {
   var remoteCallbacks;
 
   if (options) {
+    options = shallowClone(options);
     remoteCallbacks = options.remoteCallbacks;
+    delete options.remoteCallbacks;
   }
 
   options = normalizeOptions(options, NodeGit.CloneOptions);
diff --git a/lib/utils/shallow_clone.js b/lib/utils/shallow_clone.js
@@ -0,0 +1,10 @@
+module.exports = function(obj) {
+  var merges = Array.prototype.slice.call(arguments, 1);
+
+  return merges.reduce(function(obj, merge) {
+    return Object.keys(merge).reduce(function(obj, key) {
+      obj[key] = merge[key];
+      return obj;
+    }, obj);
+  }, obj || {});
+};
