Fix memory leaks

julianmesa-gitkraken · julianmesa-gitkraken · commit a24d5f814989 · 2022-10-19T12:55:49.000+02:00
diff --git a/generate/templates/partials/async_function.cc b/generate/templates/partials/async_function.cc
@@ -178,6 +178,33 @@ void {{ cppClassName }}::{{ cppFunctionName }}Worker::Execute() {
       baton->result = result;
 
     {%endif%}
+
+  {%each args|argsInfo as arg %}
+    {%if not arg.isSelf %}
+      {%if not arg.payloadFor %}
+        {%if not arg.isCallbackFunction %}
+          {%if not arg.isStructType %}
+            {%if not arg.payloadFor %}
+              {%if not arg.isStructType %}
+                {%if not arg.isReturn %}
+                  {%if not arg.isPayload %}
+                    {%if arg.name %}
+                      {%if arg.cppClassName == 'String'%}
+                        free((void*)baton->{{ arg.name }});
+                      {%endif%}
+                      {%if arg.cppClassName == 'Wrapper'%}
+                        free((void*)baton->{{ arg.name }});
+                      {%endif%}
+                    {%endif%}
+                  {%endif%}
+                {%endif%}
+              {%endif%}
+            {%endif%}
+          {%endif%}
+        {%endif%}
+      {%endif%}
+    {%endif%}
+  {%endeach%}
 }
 
 void {{ cppClassName }}::{{ cppFunctionName }}Worker::HandleErrorCallback() {
@@ -201,6 +228,17 @@ void {{ cppClassName }}::{{ cppFunctionName }}Worker::HandleErrorCallback() {
   {%each args|argsInfo as arg %}
     {%if arg.shouldAlloc %}
       {%if not arg.isCppClassStringOrArray %}
+        {%if arg.cppClassName == "GitBuf" %}
+        {%else%}
+          {%if arg | isOid %}
+            if (baton->{{ arg.name}}NeedsFree) {
+              baton->{{ arg.name}}NeedsFree = false;
+              free((void*)baton->{{ arg.name }});
+            }
+          {%else%}
+            free((void*)baton->{{ arg.name }});
+          {%endif%}
+        {%endif%}
       {%elsif arg | isOid %}
         if (baton->{{ arg.name}}NeedsFree) {
           baton->{{ arg.name}}NeedsFree = false;
@@ -346,6 +384,13 @@ void {{ cppClassName }}::{{ cppFunctionName }}Worker::HandleOKCallback() {
     {%each args|argsInfo as arg %}
       {%if arg.shouldAlloc %}
         {%if not arg.isCppClassStringOrArray %}
+          {%if arg.cppClassName == "GitBuf" %}
+          {%else%}
+            {%if arg | isOid %}
+            {%else%}
+              free((void*)baton->{{ arg.name }});
+            {%endif%}
+          {%endif%}
         {%elsif arg | isOid %}
           if (baton->{{ arg.name}}NeedsFree) {
             baton->{{ arg.name}}NeedsFree = false;
diff --git a/generate/templates/partials/sync_function.cc b/generate/templates/partials/sync_function.cc
@@ -95,9 +95,18 @@ NAN_METHOD({{ cppClassName }}::{{ cppFunctionName }}) {
 
     {%each args|argsInfo as arg %}
       {%if arg | isOid %}
-      if (info[{{ arg.jsArg }}]->IsString()) {
-        free((void *)from_{{ arg.name }});
-      }
+        if (info[{{ arg.jsArg }}]->IsString()) {
+          free((void *)from_{{ arg.name }});
+        }
+      {%else%}
+        {%if not arg.isReturn %}
+          {%if arg.cppClassName == 'String'%}
+            free((void *)from_{{ arg.name }});
+          {%endif%}
+          {%if arg.cppClassName == 'Wrapper'%}
+            free((void *)from_{{ arg.name }});
+          {%endif%}
+        {%endif%}
       {%endif%}
     {%endeach%}
 
