Allow overriding C++ standard

ianhattendorf · ianhattendorf · commit 9da0cdbd6f2f · 2022-11-04T13:50:10.000-07:00
Electron 20+ requires C++17 but older node versions only require C++14
diff --git a/generate/templates/templates/binding.gyp b/generate/templates/templates/binding.gyp
@@ -1,9 +1,14 @@
 {
   "variables": {
+    "variables": {
+      "target%": "none",
+    },
     "is_electron%": "<!(node ./utils/isBuildingForElectron.js <(node_root_dir))",
     "is_IBMi%": "<!(node -p \"os.platform() == 'aix' && os.type() == 'OS400' ? 1 : 0\")",
     "electron_openssl_root%": "<!(node ./utils/getElectronOpenSSLRoot.js <(module_root_dir))",
     "electron_openssl_static%": "<!(node -p \"process.platform !== 'linux' || process.env.NODEGIT_OPENSSL_STATIC_LINK === '1' ? 1 : 0\")",
+    "cxx_version%": "<!(node ./utils/defaultCxxStandard.js <(target))",
+    "has_cxxflags%": "<!(node -p \"process.env.CXXFLAGS ? 1 : 0\")",
     "macOS_deployment_target": "10.11"
   },
 
@@ -122,7 +127,7 @@
               "GCC_ENABLE_CPP_EXCEPTIONS": "YES",
               "MACOSX_DEPLOYMENT_TARGET": "<(macOS_deployment_target)",
               'CLANG_CXX_LIBRARY': 'libc++',
-              'CLANG_CXX_LANGUAGE_STANDARD':'c++14',
+              'CLANG_CXX_LANGUAGE_STANDARD':'c++<(cxx_version)',
 
               "WARNING_CFLAGS": [
                 "-Wno-unused-variable",
@@ -150,6 +155,7 @@
             "msvs_settings": {
               "VCCLCompilerTool": {
                 "AdditionalOptions": [
+                  "/std:c++<(cxx_version)",
                   "/EHsc"
                 ]
               },
@@ -172,10 +178,12 @@
           ]
         }],
         ["OS=='linux' or OS.endswith('bsd') or <(is_IBMi) == 1", {
-          "cflags": [
-            "-std=c++14"
-          ],
           "conditions": [
+            ["<(has_cxxflags) == 0", {
+              "cflags_cc": [
+                "-std=c++<(cxx_version)"
+              ],
+            }],
             ["<(is_electron) == 1 and <(electron_openssl_static) == 1", {
               "include_dirs": [
                 "<(electron_openssl_root)/include"
diff --git a/utils/defaultCxxStandard.js b/utils/defaultCxxStandard.js
@@ -0,0 +1,18 @@
+const targetSpecified = process.argv[2] !== 'none';
+
+let isNode18OrElectron20AndUp = false;
+if (targetSpecified) {
+  // Assume electron if target is specified.
+  // If building node 18 / 19 via target, will need to specify C++ standard manually
+  const majorVersion = process.argv[2].split('.')[0];
+  isNode18OrElectron20AndUp = majorVersion >= 20;
+} else {
+  // Node 18 === 108
+  isNode18OrElectron20AndUp = Number.parseInt(process.versions.modules) >= 108;
+}
+
+const defaultCxxStandard = isNode18OrElectron20AndUp
+  ? '17'
+  : '14';
+
+process.stdout.write(defaultCxxStandard);
