ceiling_dirs parameter in Repository.discover is optional

rcjsuen · rcjsuen · commit 98c7102a258f · 2017-12-01T07:01:48.000+09:00
libgit2's git_repository_discover function's ceiling_dirs parameter
can be null. Flag the parameter as such in the JSON file so that the
NodeGit wrapper API behaves the same way.
diff --git a/generate/input/descriptor.json b/generate/input/descriptor.json
@@ -2179,6 +2179,11 @@
       ],
       "functions": {
         "git_repository_discover": {
+          "args": {
+            "ceiling_dirs": {
+              "isOptional": true
+            }
+          },
           "isAsync": true,
           "return": {
             "isErrorCode": true
diff --git a/test/tests/repository.js b/test/tests/repository.js
@@ -200,13 +200,23 @@ describe("Repository", function() {
     });
   });
 
-  it("can discover if a path is part of a repository", function() {
+  function discover(ceiling) {
     var testPath = path.join(reposPath, "lib", "util", "normalize_oid.js");
     var expectedPath = path.join(reposPath, ".git");
-    return NodeGit.Repository.discover(testPath, 0, "")
+    return NodeGit.Repository.discover(testPath, 0, ceiling)
       .then(function(foundPath) {
         assert.equal(expectedPath, foundPath);
       });
+  }
+
+  it("can discover if a path is part of a repository, null ceiling",
+      function() {
+    return discover(null);
+  });
+
+  it("can discover if a path is part of a repository, empty ceiling",
+      function() {
+    return discover("");
   });
 
   it("can create a repo using initExt", function() {
