Skip to content

Commit 8af36d5

Browse files
committed
Reduce complexity of code
We don't need anymore the completedCallback and return callback of OnPostCallbackFn.
1 parent 74b4833 commit 8af36d5

3 files changed

Lines changed: 12 additions & 20 deletions

File tree

generate/templates/manual/include/thread_pool.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace nodegit {
1717
public:
1818
typedef std::function<void()> Callback;
1919
typedef std::function<void(Callback, Callback)> QueueCallbackFn;
20-
typedef std::function<Callback(QueueCallbackFn, Callback)> OnPostCallbackFn;
20+
typedef std::function<void(QueueCallbackFn)> OnPostCallbackFn;
2121

2222
// Initializes thread pool and spins up the requested number of threads
2323
// The provided loop will be used for completion callbacks, whenever

generate/templates/manual/src/async_baton.cc

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -45,26 +45,19 @@ namespace nodegit {
4545

4646
ThreadPool::PostCallbackEvent(
4747
[jsCallback, cancelCallback](
48-
ThreadPool::QueueCallbackFn queueCallback,
49-
ThreadPool::Callback callbackCompleted
50-
) -> ThreadPool::Callback {
48+
ThreadPool::QueueCallbackFn queueCallback
49+
) {
5150
queueCallback(jsCallback, cancelCallback);
52-
callbackCompleted();
53-
54-
return []() {};
5551
}
5652
);
5753
} else {
54+
this->onCompletion = std::bind(&AsyncBaton::SignalCompletion, this);
55+
5856
ThreadPool::PostCallbackEvent(
59-
[this, jsCallback, cancelCallback](
60-
ThreadPool::QueueCallbackFn queueCallback,
61-
ThreadPool::Callback callbackCompleted
62-
) -> ThreadPool::Callback {
63-
this->onCompletion = std::bind(&AsyncBaton::SignalCompletion, this);
64-
57+
[jsCallback, cancelCallback](
58+
ThreadPool::QueueCallbackFn queueCallback
59+
) {
6560
queueCallback(jsCallback, cancelCallback);
66-
67-
return []() {};
6861
}
6962
);
7063

generate/templates/manual/src/thread_pool.cc

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ namespace nodegit {
8181
: Event(CALLBACK_TYPE), callback(initCallback)
8282
{}
8383

84-
ThreadPool::Callback operator()(ThreadPool::QueueCallbackFn queueCb, ThreadPool::Callback completedCb) {
85-
return callback(queueCb, completedCb);
84+
void operator()(ThreadPool::QueueCallbackFn queueCb) {
85+
callback(queueCb);
8686
}
8787

8888
private:
@@ -376,11 +376,10 @@ namespace nodegit {
376376
auto callbackEvent = std::static_pointer_cast<Executor::CallbackEvent>(event);
377377

378378
LockMaster::TemporaryUnlock temporaryUnlock;
379-
auto onCompletedCallback = (*callbackEvent)(
379+
(*callbackEvent)(
380380
[this](ThreadPool::Callback callback, ThreadPool::Callback cancelCallback) {
381381
queueCallbackOnJSThread(callback, cancelCallback, false);
382-
},
383-
[]() {}
382+
}
384383
);
385384
}
386385

0 commit comments

Comments
 (0)