Merge pull request #592 from tomruggs/master

tbranyen · tbranyen · commit 6cf888f95088 · 2015-05-29T01:10:21.000-04:00
Fix for issue #591. TreeEntry.path() throws when TreeEntry came from Tree.entries()
diff --git a/lib/tree_entry.js b/lib/tree_entry.js
@@ -79,7 +79,8 @@ TreeEntry.prototype.getBlob = function(callback) {
  * @return {String}
  */
 TreeEntry.prototype.path = function(callback) {
-  return path.join(this.parent.path(), this.dirtoparent, this.filename());
+  var dirtoparent = this.dirtoparent || "";
+  return path.join(this.parent.path(), dirtoparent, this.filename());
 };
 
 /**
diff --git a/test/tests/tree_entry.js b/test/tests/tree_entry.js
@@ -1,4 +1,5 @@
 var assert = require("assert");
+var Promise = require("nodegit-promise");
 var path = require("path");
 var local = path.join.bind(path, __dirname);
 
@@ -52,6 +53,33 @@ describe("TreeEntry", function() {
       });
   });
 
+  it("provides the full path when the entry came from a tree", function(done) {
+    var testTree = function(tree, _dir) {
+      var dir = _dir || "",
+        testPromises = [];
+      tree.entries().forEach(function(entry) {
+        var currentPath = path.join(dir, entry.filename());
+        if (entry.isTree()) {
+          testPromises.push(
+            entry.getTree().then(function (subtree) {
+              return testTree(subtree, currentPath);
+            })
+          );
+        } else {
+          assert.equal(entry.path(), currentPath);
+        }
+      });
+
+      return Promise.all(testPromises);
+    };
+
+    return this.commit.getTree()
+      .then(testTree)
+      .done(function() {
+        done();
+      });
+  });
+
   it("provides the blob representation of the entry", function() {
     return this.commit.getEntry("test/raw-commit.js")
       .then(function(entry) {
