Skip to content

Commit 4d66609

Browse files
committed
add atom-shell support
1 parent 80c0f86 commit 4d66609

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

lifecycleScripts/install.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ function checkAndBuild() {
7171
}
7272
})
7373
.then(function() {
74-
return build(nwVersion);
74+
return build();
7575
});
7676
}
7777

78-
function build(nwVersion) {
78+
function build() {
7979
console.info("[nodegit] Everything is ready to go, attempting compilation");
8080
if (nwVersion) {
8181
console.info("[nodegit] Building native node-webkit module.");
@@ -93,24 +93,25 @@ function build(nwVersion) {
9393
var target = "";
9494
var debug = (process.env.BUILD_DEBUG ? " --debug" : "");
9595
var builder = "node-gyp";
96-
var dist-url = "";
96+
var distUrl = "";
9797

9898
if (asVersion) {
99-
prefix = process.platform == 'win32'
100-
? 'SET HOME="~/.atom-shell-gyp" &&s'
101-
: 'HOME=~/.atom-shell-gyp';
99+
prefix = (process.platform == "win32"
100+
? "SET HOME=\"~/.atom-shell-gyp\" && "
101+
: "HOME=~/.atom-shell-gyp";
102102

103103
target = "--target=" + asVersion;
104104

105-
dist-url = "--dist-url=https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist";
105+
distUrl = "--dist-url=https://gh-contractor-zcbenz.s3." +
106+
"amazonaws.com/atom-shell/dist";
106107
}
107108
else if (nwVersion) {
108109
builder = "nw-gyp";
109110
target = "--target=" + nwVersion;
110111
}
111112

112113
builder = path.resolve(".", "node_modules", ".bin", builder);
113-
var cmd = [prefix, builder, "rebuild", target, disturl].join(" ").trim();
114+
var cmd = [prefix, builder, "rebuild", target, debug, distUrl].join(" ").trim();
114115

115116
return exec(cmd, opts)
116117
.then(function() {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
"nodegit-promise": "~1.0.0",
6060
"npm": "^2.1.18",
6161
"promisify-node": "~0.1.2",
62-
"which-native-nodish": "^1.0.0"
62+
"which-native-nodish": "^1.0.3"
6363
},
6464
"devDependencies": {
6565
"mocha": "~2.1.0",

0 commit comments

Comments
 (0)