Add remote / refspec tests

srajko · srajko · commit 416d47f46bf8 · 2016-04-01T17:21:49.000-07:00
diff --git a/test/tests/commit.js b/test/tests/commit.js
@@ -2,32 +2,16 @@ var assert = require("assert");
 var path = require("path");
 var promisify = require("promisify-node");
 var fse = promisify(require("fs-extra"));
+
+var garbageCollect = require("../utils/garbage_collect.js");
+
 var local = path.join.bind(path, __dirname);
 
 // Have to wrap exec, since it has a weird callback signature.
 var exec = promisify(function(command, opts, callback) {
   return require("child_process").exec(command, opts, callback);
 });
 
-// aggressively collects garbage until we fail to improve terminatingIterations
-// times.
-function garbageCollect() {
-  var terminatingIterations = 3;
-  var usedBeforeGC = Number.MAX_VALUE;
-  var nondecreasingIterations = 0;
-  for ( ; ; ) {
-    global.gc();
-    var usedAfterGC = process.memoryUsage().heapUsed;
-    if (usedAfterGC >= usedBeforeGC) {
-      nondecreasingIterations++;
-      if (nondecreasingIterations >= terminatingIterations) {
-        break;
-      }
-    }
-    usedBeforeGC = usedAfterGC;
-  }
-}
-
 describe("Commit", function() {
   var NodeGit = require("../../");
   var Repository = NodeGit.Repository;
diff --git a/test/tests/remote.js b/test/tests/remote.js
@@ -2,6 +2,8 @@ var assert = require("assert");
 var path = require("path");
 var local = path.join.bind(path, __dirname);
 
+var garbageCollect = require("../utils/garbage_collect.js");
+
 describe("Remote", function() {
   var NodeGit = require("../../");
   var Repository = NodeGit.Repository;
@@ -379,4 +381,48 @@ describe("Remote", function() {
         }
       });
   });
+
+  it("is kept alive by refspec", function() {
+    var repo = this.repository;
+    var Remote = NodeGit.Remote;
+
+    garbageCollect();
+    var startSelfFreeingCount = Remote.getSelfFreeingInstanceCount();
+    var startNonSelfFreeingCount = Remote.getNonSelfFreeingConstructedCount();
+
+    var resolve;
+    var promise = new Promise(function(_resolve) { resolve = _resolve; });
+
+    var remote;
+
+    repo.getRemote("origin")
+      .then(function(_remote) {
+        remote = _remote;
+        setTimeout(resolve, 0);
+      });
+
+    return promise
+      .then(function() {
+        // make sure we have created one self-freeing remote
+        assert.equal(startSelfFreeingCount + 1,
+          Remote.getSelfFreeingInstanceCount());
+        assert.equal(startNonSelfFreeingCount,
+          Remote.getNonSelfFreeingConstructedCount());
+        var refspec = remote.getRefspec(0);
+        assert.equal("refs/heads/*", refspec.src());
+        remote = null;
+        garbageCollect();
+        // the refspec should be holding on to the remote
+        assert.equal(startSelfFreeingCount + 1,
+          Remote.getSelfFreeingInstanceCount());
+
+        assert.equal("refs/heads/*", refspec.src());
+
+        refspec = null;
+        garbageCollect();
+        // the remote should be freed now
+        assert.equal(startSelfFreeingCount,
+          Remote.getSelfFreeingInstanceCount());
+      });
+  });
 });
diff --git a/test/utils/garbage_collect.js b/test/utils/garbage_collect.js
@@ -0,0 +1,20 @@
+// aggressively collects garbage until we fail to improve terminatingIterations
+// times.
+function garbageCollect() {
+  var terminatingIterations = 3;
+  var usedBeforeGC = Number.MAX_VALUE;
+  var nondecreasingIterations = 0;
+  for ( ; ; ) {
+    global.gc();
+    var usedAfterGC = process.memoryUsage().heapUsed;
+    if (usedAfterGC >= usedBeforeGC) {
+      nondecreasingIterations++;
+      if (nondecreasingIterations >= terminatingIterations) {
+        break;
+      }
+    }
+    usedBeforeGC = usedAfterGC;
+  }
+}
+
+module.exports = garbageCollect;
