Fix TreeEntry.entryById and .getEntry

miachenmtl · miachenmtl · commit 409ebb3d5bdf · 2019-10-01T21:48:31.000-04:00
* entryById now follows pattern of entryByName and entryByIndex where the parent property is added to the entry.
* entryByPath renamed to _entryByPath since getEntry should be used instead.
* Simple test for entryById added.
* Setup of commits used in test for TreeEntry.walk moved to test setup so getEntry can test searching by path as well.
diff --git a/generate/input/descriptor.json b/generate/input/descriptor.json
@@ -4262,6 +4262,7 @@
           }
         },
         "git_tree_entry_byid": {
+          "jsFunctionName": "_entryById",
           "return": {
             "ownedByThis": true
           }
@@ -4279,6 +4280,7 @@
           }
         },
         "git_tree_entry_bypath": {
+          "jsFunctionName": "_entryByPath",
           "isAsync": true,
           "args": {
             "out": {
diff --git a/lib/tree.js b/lib/tree.js
@@ -73,6 +73,18 @@ Tree.prototype.entries = function() {
   return result;
 };
 
+/**
+ * Get an entry by oid (does not search subtrees).
+ *
+ * @param {String|Oid} id sha or Oid
+ * @return {TreeEntry}
+ */
+Tree.prototype.entryById = function(id) {
+  var entry = this._entryById(id);
+  entry.parent = this;
+  return entry;
+};
+
 /**
  * Get an entry at the ith position.
  *
@@ -107,7 +119,7 @@ Tree.prototype.entryByName = function(name) {
 Tree.prototype.getEntry = function(filePath, callback) {
   var tree = this;
 
-  return this.entryByPath(filePath).then(function(entry) {
+  return this._entryByPath(filePath).then(function(entry) {
     entry.parent = tree;
     entry.dirtoparent = path.dirname(filePath);
 
diff --git a/test/tests/tree.js b/test/tests/tree.js
@@ -10,12 +10,19 @@ describe("Tree", function() {
   var repoPath = local("../repos/tree");
   var existingPath = local("../repos/workdir");
   var oid = "5716e9757886eaf38d51c86b192258c960d9cfea";
+  var file1 = "test.txt";
+  var file2 = "foo/bar.txt";
 
   beforeEach(function() {
     var test = this;
     return RepoUtils.createRepository(repoPath)
       .then(function(repo) {
         test.repository = repo;
+        return RepoUtils.commitFileToRepo(repo, file1, "");
+      }).then(function(commit) {
+        return RepoUtils.commitFileToRepo(test.repository, file2, "", commit);
+      }).then(function(commit) {
+        test.repositoryCommit = commit;
       }).then(function() {
         return NodeGit.Repository.open(existingPath);
       }).then(function(repository) {
@@ -30,6 +37,14 @@ describe("Tree", function() {
     return fse.remove(repoPath);
   });
 
+  it("gets an entry by id",
+  function(done) {
+    this.commit.getTree().then(function(tree) {
+      var entry = tree.entryById("6cb45ba5d32532bf0d1310dc31ca4f20f59964bc");
+        assert(entry);
+    }).done(done);
+  });
+
   it("gets an entry by name",
   function(done) {
     this.commit.getTree().then(function(tree) {
@@ -38,6 +53,14 @@ describe("Tree", function() {
     }).done(done);
   });
 
+  it("gets an entry by path",
+  function(done) {
+    this.commit.getTree().then(function(tree) {
+      var entry = tree.getEntry(file2);
+        assert(entry);
+    }).done(done);
+  });
+
   it("updates a tree", function () {
     var repo = this.existingRepo;
     var update = new NodeGit.TreeUpdate();
@@ -58,20 +81,13 @@ describe("Tree", function() {
 
   it("walks its entries and returns the same entries on both progress and end",
   function() {
-    var repo = this.repository;
-    var file1 = "test.txt";
-    var file2 = "foo/bar.txt";
+    var commit = this.repositoryCommit;
+
     var expectedPaths = [file1, file2];
     var progressEntries = [];
     var endEntries;
 
-    return RepoUtils.commitFileToRepo(repo, file1, "")
-      .then(function(commit) {
-        return RepoUtils.commitFileToRepo(repo, file2, "", commit);
-      })
-      .then(function(commit) {
-        return commit.getTree();
-      })
+    return commit.getTree()
       .then(function(tree) {
         assert(tree);
 

Original file line number	Diff line number	Diff line change
`@@ -4262,6 +4262,7 @@`
`4262`	`4262`	`}`
`4263`	`4263`	`},`
`4264`	`4264`	`"git_tree_entry_byid": {`
	`4265`	`+ "jsFunctionName": "_entryById",`
`4265`	`4266`	`"return": {`
`4266`	`4267`	`"ownedByThis": true`
`4267`	`4268`	`}`
`@@ -4279,6 +4280,7 @@`
`4279`	`4280`	`}`
`4280`	`4281`	`},`
`4281`	`4282`	`"git_tree_entry_bypath": {`
	`4283`	`+ "jsFunctionName": "_entryByPath",`
`4282`	`4284`	`"isAsync": true,`
`4283`	`4285`	`"args": {`
`4284`	`4286`	`"out": {`