fix tree.walk() and add test

jdgarcia · jdgarcia · commit 3d6025281eba · 2016-02-29T15:55:32.000-07:00
diff --git a/lib/tree.js b/lib/tree.js
@@ -127,6 +127,7 @@ Tree.prototype.walk = function(blobsOnly) {
   var event = new events.EventEmitter();
 
   var total = 1;
+  var entries = [];
 
   // This looks like a DFS, but it is a BFS because of implicit queueing in
   // the recursive call to `entry.getTree(bfs)`
@@ -136,8 +137,8 @@ Tree.prototype.walk = function(blobsOnly) {
     if (error) {
       return event.emit("error", error);
     }
-    var entries = tree.entries();
-    entries.forEach(function (entry, entryIndex) {
+
+    tree.entries().forEach(function (entry, entryIndex) {
       if (!blobsOnly || entry.isFile()) {
         event.emit("entry", entry);
         entries.push(entry);
diff --git a/test/tests/tree.js b/test/tests/tree.js
@@ -0,0 +1,77 @@
+var assert = require("assert");
+var path = require("path");
+var local = path.join.bind(path, __dirname);
+var promisify = require("promisify-node");
+var fse = promisify(require("fs-extra"));
+
+describe("Tree", function() {
+  var RepoUtils = require("../utils/repository_setup");
+
+  var repoPath = local("../repos/tree");
+
+  beforeEach(function() {
+    var test = this;
+    return RepoUtils.createRepository(repoPath)
+      .then(function(repo) {
+        test.repository = repo;
+      });
+  });
+
+  after(function() {
+    return fse.remove(repoPath);
+  });
+
+  it("walks its entries and returns the same entries on both progress and end",
+  function() {
+    var repo = this.repository;
+    var progressEntries = [];
+    var endEntries;
+
+    return RepoUtils.commitFileToRepo(repo, "test.txt", "")
+      .then(function(commit) {
+        return RepoUtils.commitFileToRepo(repo, "foo/bar.txt", "", commit);
+      })
+      .then(function(commit) {
+        return commit.getTree();
+      })
+      .then(function(tree) {
+        assert(tree);
+
+        return new Promise(function (resolve, reject) {
+          var walker = tree.walk();
+
+          walker.on("entry", function(entry) {
+            progressEntries.push(entry);
+          });
+          walker.on("end", function(entries) {
+            endEntries = entries;
+            resolve();
+          });
+          walker.on("error", reject);
+
+          walker.start();
+        });
+      })
+      .then(function() {
+        assert(progressEntries.length);
+        assert(endEntries && endEntries.length);
+
+        assert.equal(
+          progressEntries.length, endEntries.length,
+          "Different number of progress entries and end entries"
+        );
+
+        function getEntryPath(entry) {
+          return entry.path();
+        }
+
+        var progressFilePaths = progressEntries.map(getEntryPath).sort();
+        var endFilePaths = endEntries.map(getEntryPath);
+
+        assert.deepEqual(
+          progressFilePaths.sort(), endFilePaths.sort(),
+          "progress entries do not match end entries"
+        );
+      });
+  });
+});
diff --git a/test/utils/repository_setup.js b/test/utils/repository_setup.js
@@ -18,18 +18,28 @@ var RepositorySetup = {
 	},
 
 	commitFileToRepo:
-	function commitFileToRepo(repository, fileName, fileContent) {
+	function commitFileToRepo(repository, fileName, fileContent, parentCommit) {
 		var repoWorkDir = repository.workdir();
 		var signature = NodeGit.Signature.create("Foo bar",
 	    "foo@bar.com", 123456789, 60);
 
-		return fse.writeFile(path.join(repoWorkDir, fileName), fileContent)
+		var filePath = path.join(repoWorkDir, fileName);
+		var parents = [];
+		if (parentCommit) {
+			parents.push(parentCommit);
+		}
+
+		// fse.ensure allows us to write files inside new folders
+		return fse.ensureFile(filePath)
+			.then(function() {
+				return fse.writeFile(filePath, fileContent);
+			})
 			.then(function() {
 				return RepositorySetup.addFileToIndex(repository, fileName);
 			})
 			.then(function(oid) {
 				return repository.createCommit("HEAD", signature, signature,
-					"initial commit", oid, []);
+					"initial commit", oid, parents);
 			})
 			.then(function(commitOid) {
 				return repository.getCommit(commitOid);
