Skip to content

Commit 1acd78f

Browse files
committed
Remove unused code
- ThreadPoolImpl doesn't need to keep a pointer of context. - Methods RunJSThreadCallbacksFromOrchestrator not used.
1 parent 7797550 commit 1acd78f

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

generate/templates/manual/src/thread_pool.cc

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -479,10 +479,6 @@ namespace nodegit {
479479

480480
void QueueCallbackOnJSThread(ThreadPool::Callback callback, ThreadPool::Callback cancelCallback, bool isWork);
481481

482-
static void RunJSThreadCallbacksFromOrchestrator(uv_async_t *handle);
483-
484-
void RunJSThreadCallbacksFromOrchestrator();
485-
486482
static void RunLoopCallbacks(uv_async_t *handle);
487483

488484
void Shutdown(std::unique_ptr<AsyncContextCleanupHandle> cleanupHandle);
@@ -498,7 +494,6 @@ namespace nodegit {
498494

499495
private:
500496
bool isMarkedForDeletion;
501-
nodegit::Context *currentContext;
502497

503498
struct JSThreadCallback {
504499
JSThreadCallback(ThreadPool::Callback callback, ThreadPool::Callback cancelCallback, bool isWork)
@@ -539,9 +534,9 @@ namespace nodegit {
539534
std::vector<Orchestrator> orchestrators;
540535
};
541536

537+
// context required to be passed to Orchestrators, but ThreadPoolImpl doesn't need to keep it
542538
ThreadPoolImpl::ThreadPoolImpl(int numberOfThreads, uv_loop_t *loop, nodegit::Context *context)
543539
: isMarkedForDeletion(false),
544-
currentContext(context),
545540
orchestratorJobMutex(new std::mutex),
546541
jsThreadCallbackMutex(new std::mutex)
547542
{

0 commit comments

Comments
 (0)