Implemented private remote tests

implausible · implausible · commit 142202786d68 · 2015-08-19T17:27:11.000-07:00
Added test to check if nodegit can fetch from a private repo with valid creds

Added test to check if nodegit cannot fetch from private repo with invalid creds
diff --git a/test/nodegit-test-rsa b/test/nodegit-test-rsa
@@ -0,0 +1,15 @@
+-----BEGIN RSA PRIVATE KEY-----
+MIICXQIBAAKBgQC5VMnDStyy3BDQ4Ilb/XnD5htRn0f3Is8NITe9o/KwZcPy2MFM
+RssnQjyp/WoQXl/o3Id+UaTZ+TKzYYmP/bGnYlyZP+FBBTKrCcDDW0fVjLbDazEX
+usAYCW58iGG9EomrwpSVrZlrLsZc1CPUdeeC8jmTuBQR7fyDFxM4sdoIyQIDAQAB
+AoGBAA7ZZ00Ze3NtRH+n7fmL5qy2jCvPClIX3OUdazzrnO9bSAb2LQ6ygWaE3R11
+q4DiPucGfGi3m/DHEbPjtcTuu8Qdqr7Nb0FU2CS2og0zMO+Z+CcyzIkXN0o7spig
+ekEY1Uml5MKGcJxu6afsOn+9LIi05SsYPCdtB5z716IewNgxAkEA2pKXov7jobMb
+2vBA4BtEtcryflWFO21uwMDHlJ34mjrUAMCX89NPrY//v8g0eYGLm9ZAj/Ik632+
+uOKHCXaG7QJBANkRBBcnKojqybJoxbL9PLJ3VoJ+EfLllGsbMHzc5VMwQF8ViwBD
+dOQ5feVKg601814Y1NGul/nprk896GNbUc0CQQCHD8iV1u1wcQ4IZyeflBoMQAFC
+YbQ3ebLTdwyc4FTLcQiqAlijOXNl67J8nskWQB+1x1oT2OxJfGVLN+d7yHstAkBz
+GKCwniXhn4z/OqrJc5mBj+GhI7PktXLzL+GP85jteUJIqKWhqCMM+KcWs2IKr/ax
+SD1gSVFwREYW4l6cgElpAkBtngXppGinh3nywIIo/SFmUJV/cUlWBi6MMgfsP8b6
+37+bqJI+m56WBdAG2xNz0uk6DIMp6R7JafOpfgOIPPk9
+-----END RSA PRIVATE KEY-----
diff --git a/test/nodegit-test-rsa.pub b/test/nodegit-test-rsa.pub
@@ -0,0 +1 @@
+ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAAgQC5VMnDStyy3BDQ4Ilb/XnD5htRn0f3Is8NITe9o/KwZcPy2MFMRssnQjyp/WoQXl/o3Id+UaTZ+TKzYYmP/bGnYlyZP+FBBTKrCcDDW0fVjLbDazEXusAYCW58iGG9EomrwpSVrZlrLsZc1CPUdeeC8jmTuBQR7fyDFxM4sdoIyQ== 
diff --git a/test/tests/remote.js b/test/tests/remote.js
@@ -11,6 +11,7 @@ describe("Remote", function() {
   var reposPath = local("../repos/workdir");
   var url = "https://github.com/nodegit/test";
   var url2 = "https://github.com/nodegit/test2";
+  var privateUrl = "git@github.com:nodegit/private";
 
   function removeNonOrigins(repo) {
     return repo.getRemotes()
@@ -163,6 +164,63 @@ describe("Remote", function() {
     });
   });
 
+  it("can fetch from a private repository", function() {
+    this.timeout(15000);
+
+    var repo = this.repository;
+    var remote = Remote.create(repo, "private", privateUrl);
+    var fetchOptions = {
+      callbacks: {
+        credentials: function(url, userName) {
+          return NodeGit.Cred.sshKeyNew(
+            userName,
+            path.resolve("./test/nodegit-test-rsa.pub"),
+            path.resolve("./test/nodegit-test-rsa"),
+            ""
+          );
+        },
+        certificateCheck: function() {
+          return 1;
+        }
+      }
+    };
+
+    return remote.fetch(null, fetchOptions, "Fetch from private")
+      .catch(function() {
+        assert.fail("Unable to fetch from private repository");
+      });
+  });
+
+  it("can reject fetching from private repository without valid " +
+    "credentials", function() {
+      this.timeout(15000);
+
+      var repo = this.repository;
+      var remote = Remote.create(repo, "private", privateUrl);
+      var fetchOptions = {
+        callbacks: {
+          credentials: function(url, userName) {
+            return NodeGit.Cred.sshKeyFromAgent(userName);
+          },
+          certificateCheck: function() {
+            return 1;
+          }
+        }
+      };
+
+      return remote.fetch(null, fetchOptions, "Fetch from private")
+        .then(function () {
+          assert.fail("Should not be able to fetch from repository");
+        })
+        .catch(function(error) {
+          assert.equal(
+            error.message.trim(),
+             "ERROR: Repository not found.",
+             "Should not be able to find repository."
+          );
+        });
+  });
+
   it("can fetch from all remotes", function() {
     // Set a reasonable timeout here for the fetchAll test
     this.timeout(15000);
@@ -183,29 +241,17 @@ describe("Remote", function() {
     });
   });
 
-  it("cannot push to a repository", function() {
+  it("cannot push to a repository with invalid credentials", function() {
     this.timeout(5000);
     var repo = this.repository;
     var branch = "should-not-exist";
     return Remote.lookup(repo, "origin")
       .then(function(remote) {
         var ref = "refs/heads/" + branch;
         var refs = [ref + ":" + ref];
-        var firstPass = true;
         var options = {
           callbacks: {
-            credentials: function(url, userName) {
-              if (firstPass) {
-                firstPass = false;
-                if (url.indexOf("https") === -1) {
-                  return NodeGit.Cred.sshKeyFromAgent(userName);
-                } else {
-                    return NodeGit.Cred.userpassPlaintextNew(userName, "");
-                }
-              } else {
-                return NodeGit.Cred.defaultNew();
-              }
-            },
+            credentials: function(url, userName, allowedTypes) {},
             certificateCheck: function() {
               return 1;
             }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAAAgQC5VMnDStyy3BDQ4Ilb/XnD5htRn0f3Is8NITe9o/KwZcPy2MFMRssnQjyp/WoQXl/o3Id+UaTZ+TKzYYmP/bGnYlyZP+FBBTKrCcDDW0fVjLbDazEXusAYCW58iGG9EomrwpSVrZlrLsZc1CPUdeeC8jmTuBQR7fyDFxM4sdoIyQ==`