Wrap toolPath in quotes instead of escaping spaces

SLaks · SLaks · commit 03f8400adb04 · 2016-01-05T10:11:41.000-05:00
For better Windows support. Fixes #850
diff --git a/lifecycleScripts/install.js b/lifecycleScripts/install.js
@@ -52,7 +52,7 @@ function installPrebuilt() {
 
 function pathForTool(name) {
   var toolPath = path.resolve(".", "node_modules", ".bin", name);
-  toolPath = toolPath.replace(/\s/g, "\\$&");
+  toolPath = '"' + toolPath + '"';
   return toolPath;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ function installPrebuilt() {`
`52`	`52`
`53`	`53`	`function pathForTool(name) {`
`54`	`54`	`var toolPath = path.resolve(".", "node_modules", ".bin", name);`
`55`		`- toolPath = toolPath.replace(/\s/g, "\\$&");`
	`55`	`+ toolPath = '"' + toolPath + '"';`
`56`	`56`	`return toolPath;`
`57`	`57`	`}`
`58`	`58`