Skip to content

Commit 3406596

Browse files
committed
submodule: completely remove reload_all
The function was removed, but its declaration and changelog entry about its removal were forgotten. The comment in the test doesn't make any sense as the function doesn't exist anymore, so get rid of it as well.
1 parent aa92c31 commit 3406596

File tree

3 files changed

+3
-13
lines changed

3 files changed

+3
-13
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,9 @@ v0.22 + 1
177177
* `git_submodule_save()` has been removed. The submodules are no
178178
longer configured via the objects.
179179

180+
* `git_submodule_reload_all()` has been removed as we no longer cache
181+
submodules.
182+
180183
### Breaking API changes
181184

182185
* `git_smart_subtransport_cb` now has a `param` parameter.

include/git2/submodule.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -583,17 +583,6 @@ GIT_EXTERN(int) git_submodule_open(
583583
*/
584584
GIT_EXTERN(int) git_submodule_reload(git_submodule *submodule, int force);
585585

586-
/**
587-
* Reread all submodule info.
588-
*
589-
* Call this to reload all cached submodule information for the repo.
590-
*
591-
* @param repo The repository to reload submodule data for
592-
* @param force Force full reload even if the data doesn't seem out of date
593-
* @return 0 on success, <0 on error
594-
*/
595-
GIT_EXTERN(int) git_submodule_reload_all(git_repository *repo, int force);
596-
597586
/**
598587
* Get the status for a submodule.
599588
*

tests/submodule/nosubs.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ void test_submodule_nosubs__add_and_delete(void)
7171
git_submodule *sm;
7272
git_buf buf = GIT_BUF_INIT;
7373

74-
/* note lack of calls to git_submodule_reload_all - this *should* work */
75-
7674
cl_git_fail(git_submodule_lookup(NULL, repo, "libgit2"));
7775
cl_git_fail(git_submodule_lookup(NULL, repo, "submodules/libgit2"));
7876

0 commit comments

Comments
 (0)