array: fix search for empty arrays

carlosmn · carlosmn · commit 1a2d8bd3c2b0 · 2016-03-23T16:51:52.000+01:00
When the array is empty `cmp` never gets set by the comparison
function. Initialize it so we return ENOTFOUND in those cases.
diff --git a/src/array.h b/src/array.h
@@ -96,7 +96,7 @@ GIT_INLINE(int) git_array__search(
 {
 	size_t lim;
 	unsigned char *part, *array = array_ptr, *base = array_ptr;
-	int cmp;
+	int cmp = -1;
 
 	for (lim = array_len; lim != 0; lim >>= 1) {
 		part = base + (lim >> 1) * item_size;

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ GIT_INLINE(int) git_array__search(`
`96`	`96`	`{`
`97`	`97`	`size_t lim;`
`98`	`98`	`unsigned char part, array = array_ptr, *base = array_ptr;`
`99`		`- int cmp;`
	`99`	`+ int cmp = -1;`
`100`	`100`
`101`	`101`	`for (lim = array_len; lim != 0; lim >>= 1) {`
`102`	`102`	`part = base + (lim >> 1) * item_size;`