From 4a2c490a6bd21a003da8f56161a54b374dd1ead8 Mon Sep 17 00:00:00 2001 From: nicola Date: Fri, 11 Dec 2015 16:42:37 -0500 Subject: [PATCH 1/2] decode uri component --- lib/utils.js | 2 ++ test/utils.js | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/lib/utils.js b/lib/utils.js index 2c543360d..1c5600e69 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -12,6 +12,8 @@ var path = require('path'); var S = require('string'); function uriToFilename(uri, base) { + console.log(uri) + uri = decodeURIComponent(uri) var filename = path.join(base, uri); // Make sure filename ends with '/' if filename exists and is a directory. // TODO this sync operation can be avoided and can be left diff --git a/test/utils.js b/test/utils.js index 9c4fac167..9319cb6f3 100644 --- a/test/utils.js +++ b/test/utils.js @@ -20,5 +20,9 @@ describe('Utility functions', function() { it('should return empty as relative path for undefined path', function() { assert.equal(utils.pathBasename(undefined), ''); }); + + it('should properly decode a uri', function() { + assert.equal(utils.uriToFilename('uri%20', 'base/'), 'base/uri ') + }); }); }); \ No newline at end of file From ea9808f2cd3e68cb586f87c0909bb46805641b8c Mon Sep 17 00:00:00 2001 From: nicola Date: Fri, 11 Dec 2015 17:01:09 -0500 Subject: [PATCH 2/2] removing debugging --- lib/utils.js | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/utils.js b/lib/utils.js index 1c5600e69..98e05036c 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -12,7 +12,6 @@ var path = require('path'); var S = require('string'); function uriToFilename(uri, base) { - console.log(uri) uri = decodeURIComponent(uri) var filename = path.join(base, uri); // Make sure filename ends with '/' if filename exists and is a directory.