Never elide an export * when --isolatedModules is set

Andy Hanson · Andy Hanson · commit e696bbcd22e5 · 2017-05-02T14:13:42.000-07:00
diff --git a/src/compiler/transformers/ts.ts b/src/compiler/transformers/ts.ts
@@ -2922,7 +2922,7 @@ namespace ts {
         function visitExportDeclaration(node: ExportDeclaration): VisitResult<Statement> {
             if (!node.exportClause) {
                 // Elide a star export if the module it references does not export a value.
-                return resolver.moduleExportsSomeValue(node.moduleSpecifier) ? node : undefined;
+                return compilerOptions.isolatedModules || resolver.moduleExportsSomeValue(node.moduleSpecifier) ? node : undefined;
             }
 
             if (!resolver.isValueAliasDeclaration(node)) {
diff --git a/tests/baselines/reference/isolatedModulesDontElideReExportStar.js b/tests/baselines/reference/isolatedModulesDontElideReExportStar.js
@@ -0,0 +1,12 @@
+//// [tests/cases/compiler/isolatedModulesDontElideReExportStar.ts] ////
+
+//// [a.ts]
+export type T = number;
+
+//// [b.ts]
+export * from "./a";
+
+
+//// [a.js]
+//// [b.js]
+export * from "./a";
diff --git a/tests/baselines/reference/isolatedModulesDontElideReExportStar.symbols b/tests/baselines/reference/isolatedModulesDontElideReExportStar.symbols
@@ -0,0 +1,8 @@
+=== /a.ts ===
+export type T = number;
+>T : Symbol(T, Decl(a.ts, 0, 0))
+
+=== /b.ts ===
+export * from "./a";
+No type information for this code.
+No type information for this code.
diff --git a/tests/baselines/reference/isolatedModulesDontElideReExportStar.types b/tests/baselines/reference/isolatedModulesDontElideReExportStar.types
@@ -0,0 +1,8 @@
+=== /a.ts ===
+export type T = number;
+>T : number
+
+=== /b.ts ===
+export * from "./a";
+No type information for this code.
+No type information for this code.
diff --git a/tests/cases/compiler/isolatedModulesDontElideReExportStar.ts b/tests/cases/compiler/isolatedModulesDontElideReExportStar.ts
@@ -0,0 +1,8 @@
+// @isolatedModules: true
+// @target: es6
+
+// @filename: /a.ts
+export type T = number;
+
+// @filename: /b.ts
+export * from "./a";

Original file line number	Diff line number	Diff line change
`@@ -2922,7 +2922,7 @@ namespace ts {`
`2922`	`2922`	`function visitExportDeclaration(node: ExportDeclaration): VisitResult<Statement> {`
`2923`	`2923`	`if (!node.exportClause) {`
`2924`	`2924`	`// Elide a star export if the module it references does not export a value.`
`2925`		`- return resolver.moduleExportsSomeValue(node.moduleSpecifier) ? node : undefined;`
	`2925`	`+ return compilerOptions.isolatedModules \|\| resolver.moduleExportsSomeValue(node.moduleSpecifier) ? node : undefined;`
`2926`	`2926`	`}`
`2927`	`2927`
`2928`	`2928`	`if (!resolver.isValueAliasDeclaration(node)) {`