for..of loops

weswigham · weswigham · commit 84551d7cbd54 · 2015-11-04T17:39:04.000-08:00
diff --git a/scripts/tslint/preferConstRule.ts b/scripts/tslint/preferConstRule.ts
@@ -105,8 +105,7 @@ class PreferConstWalker extends Lint.RuleWalker {
     private visitBindingLiteralExpression(node: ts.ArrayLiteralExpression | ts.ObjectLiteralExpression) {
         if (node.kind === ts.SyntaxKind.ObjectLiteralExpression) {
             const pattern = node as ts.ObjectLiteralExpression;
-            for (let i = 0; i < pattern.properties.length; i++) {
-                const element = pattern.properties[i];
+            for (const element of pattern.properties) {
                 if (element.name.kind === ts.SyntaxKind.Identifier) {
                     this.markAssignment(element.name as ts.Identifier)
                 }
@@ -117,16 +116,14 @@ class PreferConstWalker extends Lint.RuleWalker {
         }
         else if (node.kind === ts.SyntaxKind.ArrayLiteralExpression) {
             const pattern = node as ts.ArrayLiteralExpression;
-            for (let i = 0; i < pattern.elements.length; i++) {
-                const element = pattern.elements[i];
+            for (const element of pattern.elements) {
                 this.visitLHSExpressions(element);
             }
         }
     }
 
     private visitBindingPatternIdentifiers(pattern: ts.BindingPattern) {
-        for (let i = 0; i < pattern.elements.length; i++) {
-            const element = pattern.elements[i];
+        for (const element of pattern.elements) {
             if (element.name.kind === ts.SyntaxKind.Identifier) {
                 this.markAssignment(element.name as ts.Identifier);
             }
@@ -196,8 +193,7 @@ class PreferConstWalker extends Lint.RuleWalker {
 
     visitBlock(node: ts.Block) {
         const names: ts.Map<DeclarationUsages> = {};
-        for (let i = 0; i < node.statements.length; i++) {
-            const statement = node.statements[i];
+        for (const statement of node.statements) {
             if (statement.kind === ts.SyntaxKind.VariableStatement) {
                 this.collectLetIdentifiers((statement as ts.VariableStatement).declarationList, names);
             }
@@ -208,9 +204,7 @@ class PreferConstWalker extends Lint.RuleWalker {
     }
 
     private collectLetIdentifiers(list: ts.VariableDeclarationList, ret: ts.Map<DeclarationUsages>) {
-        const children = list.declarations;
-        for (let i = 0; i < children.length; i++) {
-            const node = children[i];
+        for (const node of list.declarations) {
             if (isLet(node) && !isExported(node)) {
                 this.collectNameIdentifiers(node, node.name, ret);
             }
@@ -227,8 +221,7 @@ class PreferConstWalker extends Lint.RuleWalker {
     }
 
     private collectBindingPatternIdentifiers(value: ts.VariableDeclaration, pattern: ts.BindingPattern, table: ts.Map<DeclarationUsages>) {
-        for (let i = 0; i < pattern.elements.length; i++) {
-            const element = pattern.elements[i];
+        for (const element of pattern.elements) {
             this.collectNameIdentifiers(value, element.name, table);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -105,8 +105,7 @@ class PreferConstWalker extends Lint.RuleWalker {`
`105`	`105`	`private visitBindingLiteralExpression(node: ts.ArrayLiteralExpression \| ts.ObjectLiteralExpression) {`
`106`	`106`	`if (node.kind === ts.SyntaxKind.ObjectLiteralExpression) {`
`107`	`107`	`const pattern = node as ts.ObjectLiteralExpression;`
`108`		`- for (let i = 0; i < pattern.properties.length; i++) {`
`109`		`- const element = pattern.properties[i];`
	`108`	`+ for (const element of pattern.properties) {`
`110`	`109`	`if (element.name.kind === ts.SyntaxKind.Identifier) {`
`111`	`110`	`this.markAssignment(element.name as ts.Identifier)`
`112`	`111`	`}`
`@@ -117,16 +116,14 @@ class PreferConstWalker extends Lint.RuleWalker {`
`117`	`116`	`}`
`118`	`117`	`else if (node.kind === ts.SyntaxKind.ArrayLiteralExpression) {`
`119`	`118`	`const pattern = node as ts.ArrayLiteralExpression;`
`120`		`- for (let i = 0; i < pattern.elements.length; i++) {`
`121`		`- const element = pattern.elements[i];`
	`119`	`+ for (const element of pattern.elements) {`
`122`	`120`	`this.visitLHSExpressions(element);`
`123`	`121`	`}`
`124`	`122`	`}`
`125`	`123`	`}`
`126`	`124`
`127`	`125`	`private visitBindingPatternIdentifiers(pattern: ts.BindingPattern) {`
`128`		`- for (let i = 0; i < pattern.elements.length; i++) {`
`129`		`- const element = pattern.elements[i];`
	`126`	`+ for (const element of pattern.elements) {`
`130`	`127`	`if (element.name.kind === ts.SyntaxKind.Identifier) {`
`131`	`128`	`this.markAssignment(element.name as ts.Identifier);`
`132`	`129`	`}`
`@@ -196,8 +193,7 @@ class PreferConstWalker extends Lint.RuleWalker {`
`196`	`193`
`197`	`194`	`visitBlock(node: ts.Block) {`
`198`	`195`	`const names: ts.Map<DeclarationUsages> = {};`
`199`		`- for (let i = 0; i < node.statements.length; i++) {`
`200`		`- const statement = node.statements[i];`
	`196`	`+ for (const statement of node.statements) {`
`201`	`197`	`if (statement.kind === ts.SyntaxKind.VariableStatement) {`
`202`	`198`	`this.collectLetIdentifiers((statement as ts.VariableStatement).declarationList, names);`
`203`	`199`	`}`
`@@ -208,9 +204,7 @@ class PreferConstWalker extends Lint.RuleWalker {`
`208`	`204`	`}`
`209`	`205`
`210`	`206`	`private collectLetIdentifiers(list: ts.VariableDeclarationList, ret: ts.Map<DeclarationUsages>) {`
`211`		`- const children = list.declarations;`
`212`		`- for (let i = 0; i < children.length; i++) {`
`213`		`- const node = children[i];`
	`207`	`+ for (const node of list.declarations) {`
`214`	`208`	`if (isLet(node) && !isExported(node)) {`
`215`	`209`	`this.collectNameIdentifiers(node, node.name, ret);`
`216`	`210`	`}`
`@@ -227,8 +221,7 @@ class PreferConstWalker extends Lint.RuleWalker {`
`227`	`221`	`}`
`228`	`222`
`229`	`223`	`private collectBindingPatternIdentifiers(value: ts.VariableDeclaration, pattern: ts.BindingPattern, table: ts.Map<DeclarationUsages>) {`
`230`		`- for (let i = 0; i < pattern.elements.length; i++) {`
`231`		`- const element = pattern.elements[i];`
	`224`	`+ for (const element of pattern.elements) {`
`232`	`225`	`this.collectNameIdentifiers(value, element.name, table);`
`233`	`226`	`}`
`234`	`227`	`}`