Fix case where we can return [undefined]

minestarks · minestarks · commit 3915d46913f7 · 2017-07-11T15:10:04.000-07:00
diff --git a/src/services/codefixes/fixUnusedIdentifier.ts b/src/services/codefixes/fixUnusedIdentifier.ts
@@ -25,15 +25,15 @@ namespace ts.codefix {
                     return [deleteNode(token.parent)];
 
                 default:
-                    return [deleteDefault()];
+                    return deleteDefault();
             }
 
-            function deleteDefault() {
+            function deleteDefault(): CodeAction[] | undefined {
                 if (isDeclarationName(token)) {
-                    return deleteNode(token.parent);
+                    return [deleteNode(token.parent)];
                 }
                 else if (isLiteralComputedPropertyDeclarationName(token)) {
-                    return deleteNode(token.parent.parent);
+                    return [deleteNode(token.parent.parent)];
                 }
                 else {
                     return undefined;
@@ -117,7 +117,7 @@ namespace ts.codefix {
                         return deleteNamedImportBinding(<NamespaceImport>parent);
 
                     default:
-                        return [deleteDefault()];
+                        return deleteDefault();
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -25,15 +25,15 @@ namespace ts.codefix {`
`25`	`25`	`return [deleteNode(token.parent)];`
`26`	`26`
`27`	`27`	`default:`
`28`		`- return [deleteDefault()];`
	`28`	`+ return deleteDefault();`
`29`	`29`	`}`
`30`	`30`
`31`		`- function deleteDefault() {`
	`31`	`+ function deleteDefault(): CodeAction[] \| undefined {`
`32`	`32`	`if (isDeclarationName(token)) {`
`33`		`- return deleteNode(token.parent);`
	`33`	`+ return [deleteNode(token.parent)];`
`34`	`34`	`}`
`35`	`35`	`else if (isLiteralComputedPropertyDeclarationName(token)) {`
`36`		`- return deleteNode(token.parent.parent);`
	`36`	`+ return [deleteNode(token.parent.parent)];`
`37`	`37`	`}`
`38`	`38`	`else {`
`39`	`39`	`return undefined;`
`@@ -117,7 +117,7 @@ namespace ts.codefix {`
`117`	`117`	`return deleteNamedImportBinding(<NamespaceImport>parent);`
`118`	`118`
`119`	`119`	`default:`
`120`		`- return [deleteDefault()];`
	`120`	`+ return deleteDefault();`
`121`	`121`	`}`
`122`	`122`	`}`
`123`	`123`