Add new lint rule

weswigham · weswigham · commit 1c5d8344be97 · 2016-06-23T12:32:14.000-07:00
diff --git a/Gulpfile.ts b/Gulpfile.ts
@@ -957,7 +957,8 @@ const tslintRules = [
     "booleanTriviaRule",
     "typeOperatorSpacingRule",
     "noInOperatorRule",
-    "noIncrementDecrementRule"
+    "noIncrementDecrementRule",
+    "objectLiteralSurroundingSpaceRule",
 ];
 const tslintRulesFiles = tslintRules.map(function(p) {
     return path.join(tslintRuleDir, p + ".ts");
diff --git a/Jakefile.js b/Jakefile.js
@@ -992,7 +992,8 @@ var tslintRules = [
     "booleanTriviaRule",
     "typeOperatorSpacingRule",
     "noInOperatorRule",
-    "noIncrementDecrementRule"
+    "noIncrementDecrementRule",
+    "objectLiteralSurroundingSpaceRule",
 ];
 var tslintRulesFiles = tslintRules.map(function(p) {
     return path.join(tslintRuleDir, p + ".ts");
diff --git a/scripts/tslint/objectLiteralSurroundingSpaceRule.ts b/scripts/tslint/objectLiteralSurroundingSpaceRule.ts
@@ -0,0 +1,32 @@
+import * as Lint from "tslint/lib/lint";
+import * as ts from "typescript";
+
+
+export class Rule extends Lint.Rules.AbstractRule {
+    public static LEADING_FAILURE_STRING = "No leading whitespace found on single-line object literal.";
+    public static TRAILING_FAILURE_STRING = "No trailing whitespace found on single-line object literal.";
+
+    public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
+        return this.applyWithWalker(new ObjectLiteralSpaceWalker(sourceFile, this.getOptions()));
+    }
+}
+
+class ObjectLiteralSpaceWalker extends Lint.RuleWalker {
+    public visitNode(node: ts.Node) {
+        if (node.kind === ts.SyntaxKind.ObjectLiteralExpression) {
+            const literal = node as ts.ObjectLiteralExpression;
+            const text = literal.getText();
+            if (text.match(/^{[^\n]+}$/g)) {
+                if (text.charAt(1) !== " ") {
+                    const failure = this.createFailure(node.pos, node.getWidth(), Rule.LEADING_FAILURE_STRING);
+                    this.addFailure(failure);
+                }
+                if (text.charAt(text.length - 2) !== " ") {
+                    const failure = this.createFailure(node.pos, node.getWidth(), Rule.TRAILING_FAILURE_STRING);
+                    this.addFailure(failure);
+                }
+            }
+        }
+        super.visitNode(node);
+    }
+}
diff --git a/tslint.json b/tslint.json
@@ -44,6 +44,7 @@
         "type-operator-spacing": true,
         "prefer-const": true,
         "no-in-operator": true,
-        "no-increment-decrement": true
+        "no-increment-decrement": true,
+        "object-literal-surrounding-space": true
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@`
`44`	`44`	`"type-operator-spacing": true,`
`45`	`45`	`"prefer-const": true,`
`46`	`46`	`"no-in-operator": true,`
`47`		`- "no-increment-decrement": true`
	`47`	`+ "no-increment-decrement": true,`
	`48`	`+ "object-literal-surrounding-space": true`
`48`	`49`	`}`
`49`	`50`	`}`