Simplify simplify simplify.

DanielRosenwasser · DanielRosenwasser · commit 15d689cdcddd · 2015-11-18T01:46:17.000-08:00
diff --git a/scripts/tslint/preferConstRule.ts b/scripts/tslint/preferConstRule.ts
@@ -112,17 +112,10 @@ class PreferConstWalker extends Lint.RuleWalker {
                     this.markAssignment((element as ts.ShorthandPropertyAssignment).name);
                 }
                 else if (kind === ts.SyntaxKind.PropertyAssignment) {
-                    const rhs = (element as ts.PropertyAssignment).initializer;
-
-                    if (rhs.kind === ts.SyntaxKind.Identifier) {
-                        this.markAssignment(rhs as ts.Identifier);
-                    }
-                    else if (rhs.kind === ts.SyntaxKind.ObjectLiteralExpression || rhs.kind === ts.SyntaxKind.ArrayLiteralExpression) {
-                        this.visitBindingLiteralExpression(rhs as ts.ObjectLiteralExpression | ts.ArrayLiteralExpression);
-                    }
-                    else {
-                        // Should be an error, but do nothing for now.
-                    }
+                    this.visitLHSExpressions((element as ts.PropertyAssignment).initializer);
+                }
+                else {
+                    // Should we throw an exception?
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -112,17 +112,10 @@ class PreferConstWalker extends Lint.RuleWalker {`
`112`	`112`	`this.markAssignment((element as ts.ShorthandPropertyAssignment).name);`
`113`	`113`	`}`
`114`	`114`	`else if (kind === ts.SyntaxKind.PropertyAssignment) {`
`115`		`- const rhs = (element as ts.PropertyAssignment).initializer;`
`116`		`-`
`117`		`- if (rhs.kind === ts.SyntaxKind.Identifier) {`
`118`		`- this.markAssignment(rhs as ts.Identifier);`
`119`		`- }`
`120`		`- else if (rhs.kind === ts.SyntaxKind.ObjectLiteralExpression \|\| rhs.kind === ts.SyntaxKind.ArrayLiteralExpression) {`
`121`		`- this.visitBindingLiteralExpression(rhs as ts.ObjectLiteralExpression \| ts.ArrayLiteralExpression);`
`122`		`- }`
`123`		`- else {`
`124`		`- // Should be an error, but do nothing for now.`
`125`		`- }`
	`115`	`+ this.visitLHSExpressions((element as ts.PropertyAssignment).initializer);`
	`116`	`+ }`
	`117`	`+ else {`
	`118`	`+ // Should we throw an exception?`
`126`	`119`	`}`
`127`	`120`	`}`
`128`	`121`	`}`