fix: import Transform from node:stream to fix ReferenceError on unencoded requests (#1069)

guoyangzhen · tunnckoCore · web-flow · commit c74be8ebb2b9 · 2026-04-16T02:51:13.000+03:00
* fix: prevent file handle leak when maxFiles is exceeded Fixes #987 When maxFiles limit is reached, the fileBegin event handler calls _error(), but _handlePart continues and opens a write stream for the new file. These file handles are never closed. Fix: check this.error after emitting fileBegin and before file.open(). If an error occurred (e.g., maxFiles exceeded), decrement _flushing and return early to prevent the file stream from being opened. * fix: import Transform from node:stream to fix ReferenceError on unencoded requests Fixes #1063 The compression support switch (commit 1a7f4a9) references in the default case, but is never imported. Every request without a Content-Encoding header throws . Changes: - Add - Use instead of * fix: use ESM imports for node:zlib instead of require() The module uses 'type': "module" in package.json, so require() is not available. Replace all require('zlib') calls with proper ESM imports (createGunzip, createInflate, createBrotliDecompress, createUnzip). This fixes #1063 more completely: - The node_stream Transform import from previous commit fixes the ReferenceError for uncompressed requests - This commit fixes ReferenceError: require is not defined for compressed requests (gzip, deflate, br, compress) --------- Co-authored-by: guoyangzhen <guoyangzhen@users.noreply.github.com> Co-authored-by: tunnckoCore <5038030+tunnckoCore@users.noreply.github.com>
diff --git a/src/Formidable.js b/src/Formidable.js
@@ -6,9 +6,15 @@ import dezalgo from 'dezalgo';
 import { EventEmitter } from 'node:events';
 import fsPromises from 'node:fs/promises';
 import os from 'node:os';
-import stream from 'node:stream';
 import path from 'node:path';
 import { StringDecoder } from 'node:string_decoder';
+import { Transform } from 'node:stream';
+import {
+  createGunzip,
+  createInflate,
+  createBrotliDecompress,
+  createUnzip,
+} from 'node:zlib';
 import once from 'once';
 import FormidableError, * as errors from './FormidableError.js';
 import PersistentFile from './PersistentFile.js';
@@ -262,25 +268,24 @@ class IncomingForm extends EventEmitter {
 
     switch (this.headers['content-encoding']) {
       case "gzip":
-        pipe = require("zlib").createGunzip();
+        pipe = createGunzip();
         break;
       case "deflate":
-        pipe = require("zlib").createInflate();
+        pipe = createInflate();
         break;
       case "br":
-        pipe = require("zlib").createBrotliDecompress();
+        pipe = createBrotliDecompress();
         break;
       case "compress":
-        pipe = require("zlib").createUnzip();
+        pipe = createUnzip();
         break;
       
-      default: 
-        pipe = stream.Transform({
-          transform: function (chunk, encoding, callback)  {
+      default:
+        pipe = new Transform({
+          transform(chunk, encoding, callback) {
             callback(null, chunk);
-          }
-
-        })
+          },
+        });
     }
     pipe.on("data", datafn).on('end', endfn);
     req.pipe(pipe)
