Repository navigation
TypeError: Invalid URL #1342
Description
Reproduction
Steps to reproduce the behavior:
- use node-fetch to request url https://r2---sn-n4v7sney.googlevideo.com
- throw error:
TypeError: Invalid URL
You can try to reproduce the issue by running the code below
const fetch = require('node-fetch')
async function getAudio() {
const ret = await fetch('https://r2---sn-n4v7sney.googlevideo.com')
const text = await ret.text()
return text
}
getAudio().catch(e => console.error(e))Expected behavior
https://r2---sn-n4v7sney.googlevideo.com is a valid url
Screenshots
Your Environment
| software | version |
|---|---|
| node-fetch | 2.6.5 |
| node | v14.18.1 |
| npm | 6.14.15 |
| Operating System | Windows 10 |
Additional context
Activity
jimmywarting commentedon Oct 21, 2021
This boils down to:
using:
And we could not use the latest whatwg-url version since v2 still supports node v4
using a older whatwg-url is by no doubt buggy...
Maybe we could rely on the built in node version if available and then fallback to whatwg if it's not available?
changing this to:
require('url').URL || whatwgUrl.URLnode-fetch/src/request.js
Line 17 in b5417ae
This will not actually fix the issue for older node versions, only hide it in newer node versions...
fyi, v3 don't have this issue cuz it uses nodes own URL
jimmywarting commentedon Oct 31, 2021
could you try 2.6.6 if it works now?
tyanbiao commentedon Nov 3, 2021
It works fine in version 2.6.6