Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: molnarg/node-http2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: node-apn/node-http2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 2 files changed
  • 3 contributors

Commits on May 1, 2016

  1. Cleanup ended streams to free memory

    Fixes #64
    argon committed May 1, 2016
    Configuration menu
    Copy the full SHA
    e4fdf71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a7f1e30 View commit details
    Browse the repository at this point in the history
  3. Fix style issues

    argon committed May 1, 2016
    Configuration menu
    Copy the full SHA
    9e36236 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2016

  1. Merge pull request #1 from simllll/master

    latest http2 including mem leak fix and stream.upstream not defined check
    florianreinhart authored Nov 8, 2016
    Configuration menu
    Copy the full SHA
    aec8aaa View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2017

  1. Remove invalid assert

    Fixes #228
    
    In the case where this._push(frame) returns null (i.e., the frame is too
    large for the window and split or the window size is <=0), moreNeeded
    will be set to null. Then this._queue.push(frame) is called, but
    moreNeeded is still null. Thus, any time the window is <=0 or the frame
    is split we'll hit the assert:
    
      var moreNeeded = null;
      if (this._queue.length === 0) {
        moreNeeded = this._push(frame);
      }
    
      if (moreNeeded === null) {
        this._queue.push(frame);
      }
    
      return moreNeeded;
    
    Credit goes to @jrabek for original version of this patch
    thughes authored and florianreinhart committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    074a654 View commit details
    Browse the repository at this point in the history
  2. Fix GOAWAY deserialization when debug data is present

    Additional debug data is allowed to be included in the GOAWAY frame:
    https://http2.github.io/http2-spec/#GOAWAY. We now put that data into
    frame.debug_data instead of returning a FRAME_SIZE_ERROR. Fixes #218
    and #219.
    thughes authored and florianreinhart committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    dff41d9 View commit details
    Browse the repository at this point in the history
Loading