framebufferio: Handle auto refresh flag at reset

jepler · jepler · commit c243c13f026a · 2020-07-20T08:52:35.000-05:00
if we don't set the flag via accessor fn the tick enable might become wrong
diff --git a/shared-module/displayio/__init__.c b/shared-module/displayio/__init__.c
@@ -190,9 +190,7 @@ void reset_displays(void) {
             common_hal_displayio_epaperdisplay_show(display, NULL);
 #if CIRCUITPY_FRAMEBUFFERIO
         } else if (displays[i].framebuffer_display.base.type == &framebufferio_framebufferdisplay_type) {
-            framebufferio_framebufferdisplay_obj_t* display = &displays[i].framebuffer_display;
-            display->auto_refresh = true;
-            common_hal_framebufferio_framebufferdisplay_show(display, NULL);
+            framebufferio_framebufferdisplay_reset(&displays[i].framebuffer_display);
 #endif
         }
     }
diff --git a/shared-module/framebufferio/FramebufferDisplay.c b/shared-module/framebufferio/FramebufferDisplay.c
@@ -318,3 +318,8 @@ void framebufferio_framebufferdisplay_collect_ptrs(framebufferio_framebufferdisp
     gc_collect_ptr(self->framebuffer);
     displayio_display_core_collect_ptrs(&self->core);
 }
+
+void framebufferio_framebufferdisplay_reset(framebufferio_framebufferdisplay_obj_t* self) {
+    common_hal_framebufferio_framebufferdisplay_set_auto_refresh(self, true);
+    common_hal_framebufferio_framebufferdisplay_show(self, NULL);
+}
diff --git a/shared-module/framebufferio/FramebufferDisplay.h b/shared-module/framebufferio/FramebufferDisplay.h
@@ -55,6 +55,7 @@ typedef struct {
 void framebufferio_framebufferdisplay_background(framebufferio_framebufferdisplay_obj_t* self);
 void release_framebufferdisplay(framebufferio_framebufferdisplay_obj_t* self);
 void reset_framebufferdisplay(framebufferio_framebufferdisplay_obj_t* self);
+void framebufferio_framebufferdisplay_reset(framebufferio_framebufferdisplay_obj_t* self);
 
 void framebufferio_framebufferdisplay_collect_ptrs(framebufferio_framebufferdisplay_obj_t* self);
 

Original file line number	Diff line number	Diff line change
`@@ -190,9 +190,7 @@ void reset_displays(void) {`
`190`	`190`	`common_hal_displayio_epaperdisplay_show(display, NULL);`
`191`	`191`	`#if CIRCUITPY_FRAMEBUFFERIO`
`192`	`192`	`} else if (displays[i].framebuffer_display.base.type == &framebufferio_framebufferdisplay_type) {`
`193`		`- framebufferio_framebufferdisplay_obj_t* display = &displays[i].framebuffer_display;`
`194`		`- display->auto_refresh = true;`
`195`		`- common_hal_framebufferio_framebufferdisplay_show(display, NULL);`
	`193`	`+ framebufferio_framebufferdisplay_reset(&displays[i].framebuffer_display);`
`196`	`194`	`#endif`
`197`	`195`	`}`
`198`	`196`	`}`
Original file line number	Diff line number	Diff line change
`@@ -318,3 +318,8 @@ void framebufferio_framebufferdisplay_collect_ptrs(framebufferio_framebufferdisp`
`318`	`318`	`gc_collect_ptr(self->framebuffer);`
`319`	`319`	`displayio_display_core_collect_ptrs(&self->core);`
`320`	`320`	`}`
	`321`	`+`
	`322`	`+void framebufferio_framebufferdisplay_reset(framebufferio_framebufferdisplay_obj_t* self) {`
	`323`	`+ common_hal_framebufferio_framebufferdisplay_set_auto_refresh(self, true);`
	`324`	`+ common_hal_framebufferio_framebufferdisplay_show(self, NULL);`
	`325`	`+}`