code for BAEL-747 after incorporating review comments (eugenp#1560)

sanaulla123 · maibin · commit 0b17547d2007 · 2017-04-01T21:51:12.000+02:00
diff --git a/algorithms/pom.xml b/algorithms/pom.xml
@@ -10,9 +10,15 @@
 		<maven-compiler-plugin.version>3.6.0</maven-compiler-plugin.version>
 		<exec-maven-plugin.version>1.5.0</exec-maven-plugin.version>
 		<lombok.version>1.16.12</lombok.version>
+		<commons-math3.version>3.6.1</commons-math3.version>
 	</properties>
 
 	<dependencies>
+		<dependency>
+            <groupId>org.apache.commons</groupId>
+            <artifactId>commons-math3</artifactId>
+            <version>${commons-math3.version}</version>
+        </dependency>
 		<dependency>
 			<groupId>junit</groupId>
 			<artifactId>junit</artifactId>
diff --git a/algorithms/src/main/java/com/baeldung/algorithms/primechecker/BigIntegerPrimeChecker.java b/algorithms/src/main/java/com/baeldung/algorithms/primechecker/BigIntegerPrimeChecker.java
@@ -1,4 +1,4 @@
-package com.baeldung.primechecker;
+package com.baeldung.algorithms.primechecker;
 
 import java.math.BigInteger;
 
diff --git a/algorithms/src/main/java/com/baeldung/algorithms/primechecker/BruteForcePrimeChecker.java b/algorithms/src/main/java/com/baeldung/algorithms/primechecker/BruteForcePrimeChecker.java
@@ -1,12 +1,12 @@
-package com.baeldung.primechecker;
+package com.baeldung.algorithms.primechecker;
 
 import java.util.stream.IntStream;
 
 public class BruteForcePrimeChecker implements PrimeChecker{
 
     @Override
     public boolean isPrime(int number) {
-        return IntStream.range(2, number).filter(n -> (number % n == 0)).count() == 0;
+        return IntStream.range(2, number).noneMatch(n -> (number % n == 0));
     }
 
     
diff --git a/algorithms/src/main/java/com/baeldung/algorithms/primechecker/OptimisedPrimeChecker.java b/algorithms/src/main/java/com/baeldung/algorithms/primechecker/OptimisedPrimeChecker.java
@@ -1,4 +1,4 @@
-package com.baeldung.primechecker;
+package com.baeldung.algorithms.primechecker;
 
 import java.util.stream.IntStream;
 
@@ -7,8 +7,7 @@ public class OptimisedPrimeChecker implements PrimeChecker{
     @Override
     public boolean isPrime(int number) {
         return IntStream.range(2, (int)Math.sqrt(number) + 1)
-            .filter(n -> (number % n == 0))
-            .count() == 0;
+            .noneMatch(n -> (number % n == 0));
     }
 
     
diff --git a/algorithms/src/main/java/com/baeldung/algorithms/primechecker/PrimeChecker.java b/algorithms/src/main/java/com/baeldung/algorithms/primechecker/PrimeChecker.java
@@ -1,4 +1,4 @@
-package com.baeldung.primechecker;
+package com.baeldung.algorithms.primechecker;
 
 public interface PrimeChecker {
     
diff --git a/algorithms/src/main/java/com/baeldung/algorithms/primechecker/PrimesPrimeChecker.java b/algorithms/src/main/java/com/baeldung/algorithms/primechecker/PrimesPrimeChecker.java
@@ -1,4 +1,4 @@
-package com.baeldung.primechecker;
+package com.baeldung.algorithms.primechecker;
 
 import org.apache.commons.math3.primes.Primes;
 
diff --git a/algorithms/src/test/java/com/baeldung/algorithms/primechecker/BigIntegerPrimeCheckerTest.java b/algorithms/src/test/java/com/baeldung/algorithms/primechecker/BigIntegerPrimeCheckerTest.java
@@ -1,9 +1,12 @@
-package com.baeldung.primechecker;
+package com.baeldung.algorithms.primechecker;
 
 import static org.junit.Assert.assertTrue;
 
 import org.junit.Test;
 
+import com.baeldung.algorithms.primechecker.BigIntegerPrimeChecker;
+import com.baeldung.algorithms.primechecker.PrimeChecker;
+
 public class BigIntegerPrimeCheckerTest {
 
     PrimeChecker primeChecker = new BigIntegerPrimeChecker();
diff --git a/algorithms/src/test/java/com/baeldung/algorithms/primechecker/BruteForcePrimeCheckerTest.java b/algorithms/src/test/java/com/baeldung/algorithms/primechecker/BruteForcePrimeCheckerTest.java
@@ -1,6 +1,9 @@
-package com.baeldung.primechecker;
+package com.baeldung.algorithms.primechecker;
 
 import org.junit.Test;
+
+import com.baeldung.algorithms.primechecker.BruteForcePrimeChecker;
+
 import static org.junit.Assert.*;
 
 public class BruteForcePrimeCheckerTest {
diff --git a/algorithms/src/test/java/com/baeldung/algorithms/primechecker/OptimisedPrimeCheckerTest.java b/algorithms/src/test/java/com/baeldung/algorithms/primechecker/OptimisedPrimeCheckerTest.java
@@ -1,9 +1,12 @@
-package com.baeldung.primechecker;
+package com.baeldung.algorithms.primechecker;
 
 import static org.junit.Assert.assertTrue;
 
 import org.junit.Test;
 
+import com.baeldung.algorithms.primechecker.OptimisedPrimeChecker;
+import com.baeldung.algorithms.primechecker.PrimeChecker;
+
 public class OptimisedPrimeCheckerTest {
 
     PrimeChecker primeChecker = new OptimisedPrimeChecker();
diff --git a/algorithms/src/test/java/com/baeldung/algorithms/primechecker/PrimesPrimeCheckerTest.java b/algorithms/src/test/java/com/baeldung/algorithms/primechecker/PrimesPrimeCheckerTest.java
@@ -1,9 +1,12 @@
-package com.baeldung.primechecker;
+package com.baeldung.algorithms.primechecker;
 
 import static org.junit.Assert.assertTrue;
 
 import org.junit.Test;
 
+import com.baeldung.algorithms.primechecker.PrimeChecker;
+import com.baeldung.algorithms.primechecker.PrimesPrimeChecker;
+
 public class PrimesPrimeCheckerTest {
     PrimeChecker primeChecker = new PrimesPrimeChecker();
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-package com.baeldung.primechecker;`
	`1`	`+package com.baeldung.algorithms.primechecker;`
`2`	`2`
`3`	`3`	`import java.math.BigInteger;`
`4`	`4`