Skip to content

Commit dc884fb

Browse files
lokeshranginenidharmisha
lokeshrangineni
authored and
dharmisha
committed
feat: Loading the CA trusted store certificate into Feast to verify the public certificate. (feast-dev#4852)
* Initial Draft version to load the CA trusted store code. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Initial Draft version to load the CA trusted store code. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Fixing the lint error. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Trying to fix the online store test cases. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Formatted the python to fix lint errors. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Fixing the unit test cases. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Fixing the unit test cases. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * removing unnecessary cli args. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Now configuring the SSL ca store configurations on the feast client side rather than on the server side. And also fixing the integration tests. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Renamed the remote registry is_tls_mode variable to is_tls. Changed the offline store TLS setting decision from cert to scheme. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Adding the existing trust store certificates to the newly created trust store. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Clearing the existing trust store configuration to see if it fixes the PR integration failures. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Clearing the existing trust store configuration to see if it fixes the PR integration failures. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Clearing the existing trust store configuration to see if it fixes the PR integration failures. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * combining the default system ca store with the custom one to fix the integration tests. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Final clean up and adding documentation. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> * Incorporating the code review comments from Francisco. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com> --------- Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
1 parent ce9cb19 commit dc884fb

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

‎sdk/python/feast/feature_store.py‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1984,13 +1984,19 @@ def serve_ui(
19841984
)
19851985

19861986
def serve_registry(
1987-
self, port: int, tls_key_path: str = "", tls_cert_path: str = ""
1987+
self,
1988+
port: int,
1989+
tls_key_path: str = "",
1990+
tls_cert_path: str = "",
19881991
) -> None:
19891992
"""Start registry server locally on a given port."""
19901993
from feast import registry_server
19911994

19921995
registry_server.start_server(
1993-
self, port=port, tls_key_path=tls_key_path, tls_cert_path=tls_cert_path
1996+
self,
1997+
port=port,
1998+
tls_key_path=tls_key_path,
1999+
tls_cert_path=tls_cert_path,
19942000
)
19952001

19962002
def serve_offline(

‎sdk/python/tests/integration/online_store/test_remote_online_store.py‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@
2222

2323

2424
@pytest.mark.integration
25+
<<<<<<< HEAD
2526
@pytest.mark.rbac_remote_integration_test
27+
=======
28+
>>>>>>> 96af22613 (feat: Loading the CA trusted store certificate into Feast to verify the public certificate. (#4852))
2629
@pytest.mark.parametrize(
2730
"tls_mode", [("True", "True"), ("True", "False"), ("False", "")], indirect=True
2831
)

0 commit comments

Comments
 (0)