Skip to content

Commit 545659a

Browse files
lokeshranginenidharmisha
authored andcommitted
feat: Building the feast image (feast-dev#4775)
Adding code to build the feast container image during the operator test run. Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
1 parent 5b48575 commit 545659a

2 files changed

Lines changed: 23 additions & 0 deletions

File tree

infra/feast-operator/Makefile

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,15 @@ docker-build: ## Build docker image with the manager.
145145
$(CONTAINER_TOOL) build -t ${IMG} .
146146

147147
## Build feast docker image.
148+
<<<<<<< HEAD
148149
.PHONY: feast-ci-dev-docker-img
149150
feast-ci-dev-docker-img:
150151
cd ./../.. && make build-feature-server-dev
152+
=======
153+
.PHONY: feast-docker-build
154+
feast-image-build:
155+
cd ./../.. && VERSION=operator.v0 REGISTRY=example.com make build-feature-transformation-server-docker
156+
>>>>>>> 779b25942 (feat: Building the feast image (#4775))
151157

152158

153159
.PHONY: docker-push

infra/feast-operator/test/e2e/e2e_test.go

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,25 @@ var _ = Describe("controller", Ordered, func() {
123123
_, cmdOutputerr := utils.Run(cmd)
124124
ExpectWithOffset(1, cmdOutputerr).NotTo(HaveOccurred())
125125

126+
<<<<<<< HEAD
126127
featureStoreName := "simple-feast-setup"
127128
validateTheFeatureStoreCustomResource(namespace, featureStoreName, timeout)
129+
=======
130+
By("building the feast image")
131+
cmd = exec.Command("make", "feast-image-build")
132+
_, err = utils.Run(cmd)
133+
ExpectWithOffset(1, err).NotTo(HaveOccurred())
134+
135+
var feastImage = "example.com/feature-transformation-server:operator.v0"
136+
By("loading the the feast image on Kind")
137+
err = utils.LoadImageToKindClusterWithName(feastImage)
138+
ExpectWithOffset(1, err).NotTo(HaveOccurred())
139+
140+
By("installing CRDs")
141+
cmd = exec.Command("make", "install")
142+
_, err = utils.Run(cmd)
143+
ExpectWithOffset(1, err).NotTo(HaveOccurred())
144+
>>>>>>> 779b25942 (feat: Building the feast image (#4775))
128145

129146
var remoteRegistryNs = "remote-registry"
130147
By(fmt.Sprintf("Creating the remote registry namespace=%s", remoteRegistryNs))

0 commit comments

Comments
 (0)