Skip to content

Commit c12e34a

Browse files
jchrysnormanmaurer
authored andcommitted
Fix flaky test (#13200)
Motivation: CipherSuiteConverterTest is flaky. since the test is not thread-safe. Modification: Make the test class executed in `@Isolated`. Result: Fix flaky test. No more fails on CipherSuiteConverterTest.
1 parent 8caf89e commit c12e34a

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

handler/src/test/java/io/netty/handler/ssl/CipherSuiteConverterTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,15 @@
1919
import io.netty.util.internal.logging.InternalLogger;
2020
import io.netty.util.internal.logging.InternalLoggerFactory;
2121
import org.junit.jupiter.api.Test;
22+
import org.junit.jupiter.api.parallel.Isolated;
2223

2324
import static org.hamcrest.MatcherAssert.assertThat;
2425
import static org.hamcrest.Matchers.is;
2526
import static org.hamcrest.Matchers.sameInstance;
2627
import static org.junit.jupiter.api.Assertions.assertEquals;
2728
import static org.junit.jupiter.api.Assertions.assertNull;
2829

30+
@Isolated
2931
public class CipherSuiteConverterTest {
3032

3133
private static final InternalLogger logger = InternalLoggerFactory.getInstance(CipherSuiteConverterTest.class);

0 commit comments

Comments
 (0)