Allow HTTP responses without reason-phrase (#14183)

normanmaurer · web-flow · commit b360abcca17b · 2024-07-16T16:41:30.000+02:00
Motivation: #14180 introduced some changes which broke the handling of HTTP responses without a reason-phrase. This change fixes it by correctly following the RFC Modifications: Correctly handle responses without reason-phrase Result: Fixes regression introduced by #14180
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java
@@ -950,9 +950,15 @@ private String[] splitInitialLine(ByteBuf asciiBuffer) {
 
         byte lastByte = asciiBytes[end - 1];
         if (isControlOrWhitespaceAsciiChar(lastByte)) {
-            // There should no extra control or whitespace char.
-            // See https://datatracker.ietf.org/doc/html/rfc2616#section-5.1
-            throw new IllegalArgumentException("Illegal character in request line: 0x" + Integer.toHexString(lastByte));
+            if (isDecodingRequest() || !isOWS(lastByte)) {
+                // There should no extra control or whitespace char in case of a request.
+                // In case of a response there might be a SP if there is no reason-phrase given.
+                // See
+                //  - https://datatracker.ietf.org/doc/html/rfc2616#section-5.1
+                //  - https://datatracker.ietf.org/doc/html/rfc9112#name-status-line
+                throw new IllegalArgumentException(
+                        "Illegal character in request line: 0x" + Integer.toHexString(lastByte));
+            }
         }
 
         final int aStart = findNonSPLenient(asciiBytes, startContent, end);
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseDecoderTest.java
@@ -1045,6 +1045,20 @@ public void testHttpMessageDecoderResult() {
         assertFalse(channel.finish());
     }
 
+    @Test
+    public void testStatusWithoutReasonPhrase() {
+        String responseStr = "HTTP/1.1 200 \r\n" +
+                "Content-Length: 0\r\n\r\n";
+        EmbeddedChannel channel = new EmbeddedChannel(new HttpResponseDecoder());
+        assertTrue(channel.writeInbound(Unpooled.copiedBuffer(responseStr, CharsetUtil.US_ASCII)));
+        HttpResponse response = channel.readInbound();
+        assertTrue(response.decoderResult().isSuccess());
+        assertEquals(HttpResponseStatus.OK, response.status());
+        HttpContent c = channel.readInbound();
+        c.release();
+        assertFalse(channel.finish());
+    }
+
     @Test
     public void testHeaderNameStartsWithControlChar1c() {
         testHeaderNameStartsWithControlChar(0x1c);
