Optimise HttpMethod#valueOf fast path lookup. (#14982)

vietj · web-flow · commit 664f20315cc4 · 2025-04-02T12:05:46.000+02:00
Motivation:

`HttpMethod#valueOf` has a fast path lookup for _GET_ and _POST_, those
call the `HttpMethod#name()` which calls `AsciiString#toString()` and
that is not necessary since we can cache the interned corresponding
strings locally like `HttpVersion#valueOf` does.

Changes:

Declare _GET_/_POST_ interned string constants and use them for fast
path lookup in `valueOf` method.

Result:

Avoid two un-necessaries method call on the fast path.
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java
@@ -26,6 +26,10 @@
  * <a href="https://en.wikipedia.org/wiki/Internet_Content_Adaptation_Protocol">ICAP</a>.
  */
 public class HttpMethod implements Comparable<HttpMethod> {
+
+    private static final String GET_STRING = "GET";
+    private static final String POST_STRING = "POST";
+
     /**
      * The OPTIONS method represents a request for information about the communication options
      * available on the request/response chain identified by the Request-URI. This method allows
@@ -41,7 +45,7 @@ public class HttpMethod implements Comparable<HttpMethod> {
      * produced data which shall be returned as the entity in the response and not the source text
      * of the process, unless that text happens to be the output of the process.
      */
-    public static final HttpMethod GET = new HttpMethod("GET");
+    public static final HttpMethod GET = new HttpMethod(GET_STRING);
 
     /**
      * The HEAD method is identical to GET except that the server MUST NOT return a message-body
@@ -54,7 +58,7 @@ public class HttpMethod implements Comparable<HttpMethod> {
      * request as a new subordinate of the resource identified by the Request-URI in the
      * Request-Line.
      */
-    public static final HttpMethod POST = new HttpMethod("POST");
+    public static final HttpMethod POST = new HttpMethod(POST_STRING);
 
     /**
      * The PUT method requests that the enclosed entity be stored under the supplied Request-URI.
@@ -107,11 +111,11 @@ public class HttpMethod implements Comparable<HttpMethod> {
      */
     public static HttpMethod valueOf(String name) {
         // fast-path
-        if (name == HttpMethod.GET.name()) {
-            return HttpMethod.GET;
+        if (name == GET_STRING) {
+            return GET;
         }
-        if (name == HttpMethod.POST.name()) {
-            return HttpMethod.POST;
+        if (name == POST_STRING) {
+            return POST;
         }
         // "slow"-path
         HttpMethod result = methodMap.get(name);
