Add support for snappy http2 content decompression (#13530)

skyguard1 · web-flow · commit 64c898307de0 · 2023-08-18T10:52:19.000+02:00
Motivation:

Since netty already supports the decompression of snappy's http content
encoding, it should also consider supporting snappy's http2 content
decompression

Modification:

Add support for snappy http content decompression

Result:

Netty supports snappy http content decompression

---------

Signed-off-by: xingrufei &lt;qhdxssm@qq.com&gt;
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2ConnectionEncoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/CompressorHttp2ConnectionEncoder.java
@@ -85,10 +85,12 @@ private static CompressionOptions[] defaultCompressionOptions() {
         if (Brotli.isAvailable()) {
             return new CompressionOptions[] {
                     StandardCompressionOptions.brotli(),
+                    StandardCompressionOptions.snappy(),
                     StandardCompressionOptions.gzip(),
                     StandardCompressionOptions.deflate() };
         }
-        return new CompressionOptions[] { StandardCompressionOptions.gzip(), StandardCompressionOptions.deflate() };
+        return new CompressionOptions[] { StandardCompressionOptions.snappy(),
+                StandardCompressionOptions.gzip(), StandardCompressionOptions.deflate() };
     }
 
     /**
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingDecompressorFrameListener.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingDecompressorFrameListener.java
@@ -23,6 +23,7 @@
 import io.netty.handler.codec.compression.BrotliDecoder;
 import io.netty.handler.codec.compression.ZlibCodecFactory;
 import io.netty.handler.codec.compression.ZlibWrapper;
+import io.netty.handler.codec.compression.SnappyFrameDecoder;
 import io.netty.util.internal.UnstableApi;
 
 import static io.netty.handler.codec.http.HttpHeaderNames.CONTENT_ENCODING;
@@ -33,6 +34,7 @@
 import static io.netty.handler.codec.http.HttpHeaderValues.IDENTITY;
 import static io.netty.handler.codec.http.HttpHeaderValues.X_DEFLATE;
 import static io.netty.handler.codec.http.HttpHeaderValues.X_GZIP;
+import static io.netty.handler.codec.http.HttpHeaderValues.SNAPPY;
 import static io.netty.handler.codec.http2.Http2Error.INTERNAL_ERROR;
 import static io.netty.handler.codec.http2.Http2Exception.streamError;
 import static io.netty.util.internal.ObjectUtil.checkNotNull;
@@ -182,6 +184,10 @@ protected EmbeddedChannel newContentDecompressor(final ChannelHandlerContext ctx
             return new EmbeddedChannel(ctx.channel().id(), ctx.channel().metadata().hasDisconnect(),
               ctx.channel().config(), new BrotliDecoder());
         }
+        if (SNAPPY.contentEqualsIgnoreCase(contentEncoding)) {
+            return new EmbeddedChannel(ctx.channel().id(), ctx.channel().metadata().hasDisconnect(),
+                    ctx.channel().config(), new SnappyFrameDecoder());
+        }
         // 'identity' or unsupported
         return null;
     }

Original file line number	Diff line number	Diff line change
`@@ -85,10 +85,12 @@ private static CompressionOptions[] defaultCompressionOptions() {`
`85`	`85`	`if (Brotli.isAvailable()) {`
`86`	`86`	`return new CompressionOptions[] {`
`87`	`87`	`StandardCompressionOptions.brotli(),`
	`88`	`+ StandardCompressionOptions.snappy(),`
`88`	`89`	`StandardCompressionOptions.gzip(),`
`89`	`90`	`StandardCompressionOptions.deflate() };`
`90`	`91`	`}`
`91`		`- return new CompressionOptions[] { StandardCompressionOptions.gzip(), StandardCompressionOptions.deflate() };`
	`92`	`+ return new CompressionOptions[] { StandardCompressionOptions.snappy(),`
	`93`	`+ StandardCompressionOptions.gzip(), StandardCompressionOptions.deflate() };`
`92`	`94`	`}`
`93`	`95`
`94`	`96`	`/**`