Replace LinkedList with ArrayList (#13016)

needmorecode · normanmaurer · web-flow · commit 3bff0bee692b · 2022-11-24T14:34:25.000+01:00
Motivation:

ArrayList is more efficient than LinkedList in the space cost.
ArrayList is almost as efficient as LinkedList in the time cost of tail insertion, which are the practical use cases of the two lists I modified.

Modification:

Replace LinkedList with ArrayList.

Result:

Less space cost.

Co-authored-by: Norman Maurer &lt;norman_maurer@apple.com&gt;
diff --git a/codec-xml/src/main/java/io/netty/handler/codec/xml/XmlElement.java b/codec-xml/src/main/java/io/netty/handler/codec/xml/XmlElement.java
@@ -15,7 +15,7 @@
  */
 package io.netty.handler.codec.xml;
 
-import java.util.LinkedList;
+import java.util.ArrayList;
 import java.util.List;
 
 /**
@@ -28,7 +28,7 @@ public abstract class XmlElement {
     private final String namespace;
     private final String prefix;
 
-    private final List<XmlNamespace> namespaces = new LinkedList<XmlNamespace>();
+    private final List<XmlNamespace> namespaces = new ArrayList<XmlNamespace>();
 
     protected XmlElement(String name, String namespace, String prefix) {
         this.name = name;
diff --git a/codec-xml/src/main/java/io/netty/handler/codec/xml/XmlElementStart.java b/codec-xml/src/main/java/io/netty/handler/codec/xml/XmlElementStart.java
@@ -15,15 +15,15 @@
  */
 package io.netty.handler.codec.xml;
 
-import java.util.LinkedList;
+import java.util.ArrayList;
 import java.util.List;
 
 /**
  * Specific {@link XmlElement} representing beginning  of element.
  */
 public class XmlElementStart extends XmlElement {
 
-    private final List<XmlAttribute> attributes = new LinkedList<XmlAttribute>();
+    private final List<XmlAttribute> attributes = new ArrayList<XmlAttribute>();
 
     public XmlElementStart(String name, String namespace, String prefix) {
         super(name, namespace, prefix);
