Use PlatformDependent.threadLocalRandom() to reduce memory footprint (#13977)

jchrys · web-flow · commit 0e436dd45049 · 2024-04-15T07:55:34.000+02:00
Motivation:
Direct use of `io.netty.util.internal.ThreadLocalRandom` and
`j.u.c.ThreadLocalRandom` could cause a lot of memory waste.

Modifications:
Use `PlatformDependent.threadLocalRandom()`.

Result:
Reduced Memory footprint.
diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryIdSpace.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryIdSpace.java
@@ -17,7 +17,6 @@
 
 import io.netty.util.internal.MathUtil;
 import io.netty.util.internal.PlatformDependent;
-import io.netty.util.internal.ThreadLocalRandom;
 
 import java.util.Random;
 
@@ -62,7 +61,7 @@ int nextId() {
                 }
             } else if (freeIdx == -1 ||
                     // Let's make it somehow random which free slot is used.
-                    ThreadLocalRandom.current().nextBoolean()) {
+                    PlatformDependent.threadLocalRandom().nextBoolean()) {
                     // We have a slot that we can use to create a new bucket if we need to.
                     freeIdx = bucketIdx;
             }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`
`18`	`18`	`import io.netty.util.internal.MathUtil;`
`19`	`19`	`import io.netty.util.internal.PlatformDependent;`
`20`		`-import io.netty.util.internal.ThreadLocalRandom;`
`21`	`20`
`22`	`21`	`import java.util.Random;`
`23`	`22`
`@@ -62,7 +61,7 @@ int nextId() {`
`62`	`61`	`}`
`63`	`62`	`} else if (freeIdx == -1 \|\|`
`64`	`63`	`// Let's make it somehow random which free slot is used.`
`65`		`- ThreadLocalRandom.current().nextBoolean()) {`
	`64`	`+ PlatformDependent.threadLocalRandom().nextBoolean()) {`
`66`	`65`	`// We have a slot that we can use to create a new bucket if we need to.`
`67`	`66`	`freeIdx = bucketIdx;`
`68`	`67`	`}`