Due to the use of unsupported APIs, we must remove the LocalAccounts module until a better solution is found. (PowerShell#4302)

TravisEz13 · web-flow · commit f1ff79011dff · 2017-07-19T17:20:35.000-07:00
diff --git a/build.psm1 b/build.psm1
@@ -2961,7 +2961,6 @@ function Start-CrossGen {
         $psCoreAssemblyList += @(
             "Microsoft.WSMan.Management.dll",
             "Microsoft.WSMan.Runtime.dll",
-            "Microsoft.PowerShell.LocalAccounts.dll",
             "Microsoft.PowerShell.Commands.Diagnostics.dll",
             "Microsoft.Management.Infrastructure.CimCmdlets.dll"
         )
diff --git a/src/Modules/Windows-Full/Microsoft.PowerShell.LocalAccounts/LocalAccounts.format.ps1xml b/src/Modules/Windows-Full/Microsoft.PowerShell.LocalAccounts/LocalAccounts.format.ps1xml
diff --git a/src/Modules/Windows-Full/Microsoft.PowerShell.LocalAccounts/Microsoft.PowerShell.LocalAccounts.psd1 b/src/Modules/Windows-Full/Microsoft.PowerShell.LocalAccounts/Microsoft.PowerShell.LocalAccounts.psd1
diff --git a/src/powershell-win-core/powershell-win-core.csproj b/src/powershell-win-core/powershell-win-core.csproj
@@ -33,7 +33,6 @@
     <ProjectReference Include="..\Microsoft.PowerShell.SDK\Microsoft.PowerShell.SDK.csproj" />
     <ProjectReference Include="..\Microsoft.PowerShell.PSReadLine\Microsoft.PowerShell.PSReadLine.csproj" />
     <ProjectReference Include="..\Microsoft.PowerShell.Commands.Diagnostics\Microsoft.PowerShell.Commands.Diagnostics.csproj" />
-    <ProjectReference Include="..\Microsoft.PowerShell.LocalAccounts\Microsoft.PowerShell.LocalAccounts.csproj" />
     <ProjectReference Include="..\Microsoft.Management.Infrastructure.CimCmdlets\Microsoft.Management.Infrastructure.CimCmdlets.csproj" />
     <ProjectReference Include="..\Microsoft.WSMan.Management\Microsoft.WSMan.Management.csproj" />
   </ItemGroup>
diff --git a/test/fullclr/PowerShellGithubDev.Tests.ps1 b/test/fullclr/PowerShellGithubDev.Tests.ps1
@@ -48,6 +48,8 @@ try
     # this Describe makes sure we binplace all the files, like psd1, psm1, ps1xml and load usable modules from them
     Describe 'Modules for the package' {
         Context '$env:DEVPATH Modules loading' {
+            <#
+            removed due to #4272
             It 'loads Microsoft.PowerShell.LocalAccounts' {
                 try
                 {
@@ -59,6 +61,7 @@ try
                     Remove-Module -ErrorAction SilentlyContinue Microsoft.PowerShell.LocalAccounts
                 }
             }
+            #>
 
             It 'loads Microsoft.PowerShell.Archive' {
                 try
diff --git a/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroup.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroup.Tests.ps1
@@ -2,6 +2,11 @@
 #
 # Copyright (c) Microsoft Corporation, 2015
 
+# Module removed due to #4272
+# disabling tests
+
+return
+
 function RemoveTestGroups
 {
     param([string] $basename)
diff --git a/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroupMember.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalGroupMember.Tests.ps1
@@ -2,6 +2,11 @@
 #
 # Copyright (c) Microsoft Corporation, 2015
 
+# Module removed due to #4272
+# disabling tests
+
+return
+
 function IsWin10OrHigher
 {
     $version = [system.environment]::osversion.version
diff --git a/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalUser.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.LocalAccounts/Pester.Command.Cmdlets.LocalAccounts.LocalUser.Tests.ps1
@@ -2,6 +2,11 @@
 #
 # Copyright (c) Microsoft Corporation, 2015
 
+# Module removed due to #4272
+# disabling tests
+
+return
+
 Set-Variable dateInFuture -option Constant -value "12/12/2036 09:00"
 Set-Variable dateInPast -option Constant -value "12/12/2010 09:00"
 Set-Variable dateInvalid -option Constant -value "12/12/2016 25:00"
diff --git a/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1 b/test/powershell/engine/Help/UpdatableHelpSystem.Tests.ps1
@@ -12,7 +12,7 @@ $powershellCoreModules = @(
     "Microsoft.PowerShell.Core"
     "Microsoft.PowerShell.Diagnostics"
     "Microsoft.PowerShell.Management"
-    "Microsoft.PowerShell.LocalAccounts"
+    # "Microsoft.PowerShell.LocalAccounts" removed due to #4274
     "Microsoft.PowerShell.Security"
     "Microsoft.PowerShell.Utility"
     "Microsoft.WsMan.Management"
diff --git a/test/tools/OpenCover/OpenCover.psm1 b/test/tools/OpenCover/OpenCover.psm1
@@ -232,7 +232,6 @@ function Expand-ZipArchive([string] $Path, [string] $DestinationPath)
    Microsoft.PowerShell.PackageManagement              59.77  62.04    Branch:59.77 Sequence:62.04
    Microsoft.PackageManagement                         41.73  44.47    Branch:41.73 Sequence:44.47
    Microsoft.Management.Infrastructure.CimCmdlets      13.20  17.01    Branch:13.20 Sequence:17.01
-   Microsoft.PowerShell.LocalAccounts                  73.15  84.32    Branch:73.15 Sequence:84.32
    Microsoft.PackageManagement.MetaProvider.PowerShell 54.79  57.90    Branch:54.79 Sequence:57.90
    Microsoft.PackageManagement.NuGetProvider           62.36  65.37    Branch:62.36 Sequence:65.37
    Microsoft.PackageManagement.CoreProviders           7.08   7.96     Branch:7.08 Sequence:7.96
@@ -285,7 +284,6 @@ function Get-CodeCoverage
    Microsoft.PowerShell.ConsoleHost                    36.53            0 38.40                0
    Microsoft.PowerShell.CoreCLR.AssemblyLoadContext    53.66            0 95.31                0
    Microsoft.PowerShell.CoreCLR.Eventing               28.70            0 36.23                0
-   Microsoft.PowerShell.LocalAccounts                  73.15            0 84.32                0
    Microsoft.PowerShell.PackageManagement              59.77            0 62.04                0
    Microsoft.PowerShell.PSReadLine                     7.12             0 9.94                 0
    Microsoft.PowerShell.Security                       15.17            0 18.16                0
@@ -312,7 +310,6 @@ function Get-CodeCoverage
    Microsoft.PowerShell.ConsoleHost                    36.53            0 38.40                0
    Microsoft.PowerShell.CoreCLR.AssemblyLoadContext    53.66            0 95.31                0
    Microsoft.PowerShell.CoreCLR.Eventing               28.70            0 36.23                0
-   Microsoft.PowerShell.LocalAccounts                  73.15            0 84.32                0
    Microsoft.PowerShell.PackageManagement              59.77            0 62.04                0
    Microsoft.PowerShell.PSReadLine                     7.12             0 9.94                 0
    Microsoft.PowerShell.Security                       15.17            0 18.16                0

Original file line number	Diff line number	Diff line change
`@@ -2961,7 +2961,6 @@ function Start-CrossGen {`
`2961`	`2961`	`$psCoreAssemblyList += @(`
`2962`	`2962`	`"Microsoft.WSMan.Management.dll",`
`2963`	`2963`	`"Microsoft.WSMan.Runtime.dll",`
`2964`		`- "Microsoft.PowerShell.LocalAccounts.dll",`
`2965`	`2964`	`"Microsoft.PowerShell.Commands.Diagnostics.dll",`
`2966`	`2965`	`"Microsoft.Management.Infrastructure.CimCmdlets.dll"`
`2967`	`2966`	`)`
Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,8 @@ try`
`48`	`48`	`# this Describe makes sure we binplace all the files, like psd1, psm1, ps1xml and load usable modules from them`
`49`	`49`	`Describe 'Modules for the package' {`
`50`	`50`	`Context '$env:DEVPATH Modules loading' {`
	`51`	`+ <#`
	`52`	`+ removed due to #4272`
`51`	`53`	`It 'loads Microsoft.PowerShell.LocalAccounts' {`
`52`	`54`	`try`
`53`	`55`	`{`
`@@ -59,6 +61,7 @@ try`
`59`	`61`	`Remove-Module -ErrorAction SilentlyContinue Microsoft.PowerShell.LocalAccounts`
`60`	`62`	`}`
`61`	`63`	`}`
	`64`	`+ #>`
`62`	`65`
`63`	`66`	`It 'loads Microsoft.PowerShell.Archive' {`
`64`	`67`	`try`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,11 @@`
`2`	`2`	`#`
`3`	`3`	`# Copyright (c) Microsoft Corporation, 2015`
`4`	`4`
	`5`	`+# Module removed due to #4272`
	`6`	`+# disabling tests`
	`7`	`+`
	`8`	`+return`
	`9`	`+`
`5`	`10`	`function RemoveTestGroups`
`6`	`11`	`{`
`7`	`12`	`param([string] $basename)`