Skip to content

Commit b5b0244

Browse files
committed
Stop interacting w/ DOM in onBeforeRequest
(Inspired by @jsha's commit 900bedc) Remove DOM manipulation and use URI() instead. Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
1 parent 0aa4bbf commit b5b0244

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

‎chromium/background.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,9 +191,8 @@ function onBeforeSendHeaders(details) {
191191
for (var h in details.requestHeaders) {
192192
if (details.requestHeaders[h].name == "Cookie") {
193193
// Per RFC 6265, Chrome sends only ONE cookie header, period.
194-
var a = document.createElement("a");
195-
a.href = details.url;
196-
var host = a.hostname;
194+
var uri = new URI(details.url);
195+
var host = uri.hostname();
197196

198197
var newCookies = [];
199198
var cookies = details.requestHeaders[h].value.split(";");

0 commit comments

Comments
 (0)