From abb7821db0760675730c8f8dc453c427062943d6 Mon Sep 17 00:00:00 2001 From: Sandro Ciervo Date: Thu, 18 Sep 2025 11:06:01 +0200 Subject: [PATCH 1/2] Disables SA1615 and S3900 in test rulesets --- CHANGELOG.md | 5 +++++ Neolution.CodeAnalysis.nuspec | 3 ++- build/Neolution.CodeAnalysis.TestsRuleset.globalconfig | 10 +++++++++- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0a02f0c..8774b10 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,11 @@ and adheres to a project-specific [Versioning](/README.md). ## [Unreleased] +### Removed + +- [Tests ruleset] SA1615: Element return value should be documented +- [Tests ruleset] S3900: Validate arguments of public methods + ## [3.2.1] - 2024-11-18 ### Fixed diff --git a/Neolution.CodeAnalysis.nuspec b/Neolution.CodeAnalysis.nuspec index 17f5ff8..2eff755 100644 --- a/Neolution.CodeAnalysis.nuspec +++ b/Neolution.CodeAnalysis.nuspec @@ -5,12 +5,13 @@ {{NuGetVersion}} Neolution Code Analysis Neolution AG - Configures Code Analysis for Neolution Projects + Configures Code Analysis for Neolution Projects. https://github.com/neolution-ch/Neolution.CodeAnalysis docs\README.md MIT false true + See CHANGELOG.md for release notes and version history. diff --git a/build/Neolution.CodeAnalysis.TestsRuleset.globalconfig b/build/Neolution.CodeAnalysis.TestsRuleset.globalconfig index 2a230fb..d1fc69b 100644 --- a/build/Neolution.CodeAnalysis.TestsRuleset.globalconfig +++ b/build/Neolution.CodeAnalysis.TestsRuleset.globalconfig @@ -43,4 +43,12 @@ dotnet_diagnostic.S4581.severity = suggestion # S4144: Methods should not have identical implementations ; When using parameterised tests it can make sense to have different test methods with different parametrization but using the same implementation. -dotnet_diagnostic.S4144.severity = none \ No newline at end of file +dotnet_diagnostic.S4144.severity = none + +# SA1615: Element return value should be documented +; This adds no value in tests +dotnet_diagnostic.SA1615.severity = none + +# Validate arguments of public methods +; Generally adds limited value and can often be counterproductive in test projects +dotnet_diagnostic.S3900.severity = none From 14f57f952d568c7e9932cf84a8eed8f0f92f5426 Mon Sep 17 00:00:00 2001 From: GitHub Release Bot Date: Thu, 18 Sep 2025 09:08:46 +0000 Subject: [PATCH 2/2] Release 3.2.2 --- CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8774b10..a82f32b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ and adheres to a project-specific [Versioning](/README.md). ## [Unreleased] +## [3.2.2] - 2025-09-18 + ### Removed - [Tests ruleset] SA1615: Element return value should be documented @@ -169,7 +171,7 @@ and adheres to a project-specific [Versioning](/README.md). - Changelog -[unreleased]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.2.1...HEAD +[unreleased]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.2.2...HEAD [3.1.0]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.0.5...v3.1.0 [3.0.5]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.0.4...v3.0.5 [3.0.4]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.0.3...v3.0.4 @@ -178,6 +180,7 @@ and adheres to a project-specific [Versioning](/README.md). [3.0.1]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.0.0...v3.0.1 [3.0.0]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v2.7.1...v3.0.0 [2.7.1]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v2.7.0...v2.7.1 +[3.2.2]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.2.1...v3.2.2 [3.2.1]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.2.0...v3.2.1 [3.2.0]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.1.2...v3.2.0 [3.1.2]: https://github.com/neolution-ch/Neolution.CodeAnalysis/compare/v3.1.1...v3.1.2