fixed SmsDeliver parsing on missing SMSC address

zoltanszekely · zoltanszekely · commit fe4fa83c18b6 · 2010-10-07T11:03:46.000+01:00
diff --git a/messaging/sms/deliver.py b/messaging/sms/deliver.py
@@ -68,17 +68,17 @@ def _set_pdu(self, pdu):
         data = to_array(self._pdu)
 
         # Service centre address
-        smscl = data.pop(0) - 1
-
-        smscertype = data.pop(0)
-        smscer = swap_number(encode_bytes(data[:smscl]))
-
-        data = data[smscl:]
-
-        if (smscertype >> 4) & 0x07 == consts.INTERNATIONAL:
-            smscer = '+%s' % smscer
+        smscl = data.pop(0)
+        if smscl > 0:
+            smscertype = data.pop(0)
+            smscl -= 1
+            self.csca = swap_number(encode_bytes(data[:smscl]))
+            if (smscertype >> 4) & 0x07 == consts.INTERNATIONAL:
+                self.csca = '+%s' % self.csca
+            data = data[smscl:]
+        else:
+            self.csca = None
 
-        self.csca = smscer
         # 1 byte(octet) == 2 char
         # Message type TP-MTI bits 0,1
         # More messages to send/deliver bit 2
