Skip to content

Commit 43dfecd

Browse files
committed
restore required mallforms
1 parent 9df6c17 commit 43dfecd

3 files changed

Lines changed: 10 additions & 6 deletions

File tree

.github/workflows/coding_standard.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ jobs:
1515
php-version: 7.4
1616
coverage: none
1717

18-
- run: composer install --no-progress
18+
- run: composer install --no-progress --ansi
1919

2020
- run: vendor/bin/ecs check-markdown README.md --ansi

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ declare(strict_types=1);
453453
$a = '42';
454454
$b = 42;
455455

456-
if ($a !== $b) {
456+
if ($a != $b) {
457457
// The expression will always pass
458458
}
459459
```
@@ -862,8 +862,8 @@ function splitIntoFirstAndLastName(): void
862862

863863
splitIntoFirstAndLastName();
864864

865-
// ['Ryan', 'McDermott'];
866865
var_dump($name);
866+
// ['Ryan', 'McDermott'];
867867
```
868868

869869
**Good:**
@@ -879,10 +879,11 @@ function splitIntoFirstAndLastName(string $name): array
879879
$name = 'Ryan McDermott';
880880
$newName = splitIntoFirstAndLastName($name);
881881

882-
// 'Ryan McDermott';
883882
var_dump($name);
884-
// ['Ryan', 'McDermott'];
883+
// 'Ryan McDermott';
884+
885885
var_dump($newName);
886+
// ['Ryan', 'McDermott'];
886887
```
887888

888889
**[⬆ back to top](#table-of-contents)**

ecs.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
declare(strict_types=1);
44

5+
use PhpCsFixer\Fixer\PhpTag\BlankLineAfterOpeningTagFixer;
6+
use PhpCsFixer\Fixer\Strict\StrictComparisonFixer;
57
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
68
use Symplify\EasyCodingStandard\ValueObject\Option;
79
use Symplify\EasyCodingStandard\ValueObject\Set\SetList;
@@ -22,6 +24,7 @@
2224
]);
2325

2426
$parameters->set(Option::SKIP, [
25-
\PhpCsFixer\Fixer\PhpTag\BlankLineAfterOpeningTagFixer::class => null,
27+
BlankLineAfterOpeningTagFixer::class => null,
28+
StrictComparisonFixer::class => null,
2629
]);
2730
};

0 commit comments

Comments
 (0)