Skip to content

Commit 84a0851

Browse files
committed
Fix 411 with PUT request
with data as None, requests module didn't add specific header
1 parent 9e7d4e6 commit 84a0851

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

github3/api.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,9 @@ def patch(self, request, data=None, **kwargs):
7272

7373
def put(self, request, **kwargs):
7474
""" PUT request """
75-
# Content-length: 0 to headers ?
76-
response = self._request('PUT', request, **kwargs)
75+
76+
response = self._request('PUT', request,
77+
headers={'Content-length': '0'}, **kwargs)
7778
assert response.status_code == 204
7879
return response
7980

github3/tests/api_test.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,3 +113,12 @@ def test_delete(self, request_method):
113113
delete = self.gh.delete('core')
114114
request_method.assert_called_with(
115115
'DELETE', self.base_url + 'core')
116+
117+
def test_put(self, request_method):
118+
response = request_method.return_value
119+
response.status_code = 204
120+
response.content = ''
121+
put = self.gh.put('core')
122+
request_method.assert_called_with(
123+
'PUT', self.base_url + 'core',
124+
headers={'Content-length': '0'})

0 commit comments

Comments
 (0)