Override always default Android hostname verifier

Guatom · web-flow · commit 1a8c970fbaca · 2018-02-06T16:59:06.000-03:00
This fixes the following problem: javax.net.ssl.SSLPeerUnverifiedException: Hostname WWW.XXX.YYY.ZZZ not verified: ... ... subjectAltNames: [] ; Zone: <root> ; Task: Promise.then ; Value: javax.net.ssl.SSLPeerUnverifiedException: Hostname WWW.XXX.YYY.ZZZ not verified:
diff --git a/https.android.ts b/https.android.ts
@@ -136,23 +136,22 @@ function getClient(reload: boolean = false): okhttp3.OkHttpClient {
 				}
 			}
 
-			if (peer.validatesDomainName == true) {
-				try {
-					client.hostnameVerifier(new javax.net.ssl.HostnameVerifier({
-						verify: function(hostname: string, session: javax.net.ssl.ISSLSession): boolean {
-							let pp = session.getPeerPrincipal().getName()
-							let hv = javax.net.ssl.HttpsURLConnection.getDefaultHostnameVerifier()
-							return (
-								hv.verify(peer.host, session) &&
-								peer.host == hostname &&
-								peer.host == session.getPeerHost() &&
-								pp.indexOf(peer.host) != -1
-							)
-						},
-					}))
-				} catch (error) {
-					console.error('nativescript-https > client.validatesDomainName error', error)
-				}
+			try {
+				client.hostnameVerifier(new javax.net.ssl.HostnameVerifier({
+					verify: function(hostname: string, session: javax.net.ssl.ISSLSession): boolean {
+						let pp = session.getPeerPrincipal().getName()
+						let hv = javax.net.ssl.HttpsURLConnection.getDefaultHostnameVerifier()
+						return (
+							!peer.validatesDomainName ||
+							hv.verify(peer.host, session) &&
+							peer.host == hostname &&
+							peer.host == session.getPeerHost() &&
+							pp.indexOf(peer.host) != -1
+						)
+					},
+				}))
+			} catch (error) {
+				console.error('nativescript-https > client.validatesDomainName error', error)
 			}
 
 		} else {
