Skip to content

Commit 1d476be

Browse files
committed
JavaCL: removed defunc non-raw low-level bindings
1 parent 3fb6d5b commit 1d476be

File tree

4 files changed

+7
-35
lines changed

4 files changed

+7
-35
lines changed

Core/src/main/velocity/com/nativelibs4java/opencl/CLBuffer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,9 @@ public CLBuffer<T> createSubBuffer(Usage usage, long offset, long length) {
8989
int s = getElementSize();
9090
cl_buffer_region region = new cl_buffer_region().origin(s * offset).size(s * length);
9191
#declareReusablePtrsAndPErr()
92-
cl_mem mem = CL.clCreateSubBuffer(getEntity(), usage.getIntFlags(), CL_BUFFER_CREATE_TYPE_REGION, pointerTo(region), pErr);
92+
long mem = CL.clCreateSubBuffer(getEntityPeer(), usage.getIntFlags(), CL_BUFFER_CREATE_TYPE_REGION, getPeer(pointerTo(region)), getPeer(pErr));
9393
#checkPErr()
94-
return mem == null ? null : new CLBuffer<T>(context, length * s, getPeer(mem), null, io);
94+
return mem == 0 ? null : new CLBuffer<T>(context, length * s, mem, null, io);
9595
} catch (Throwable th) {
9696
// TODO check if supposed to handle OpenCL 1.1
9797
throw new UnsupportedOperationException("Cannot create sub-buffer (OpenCL 1.1 feature).", th);

Core/src/main/velocity/com/nativelibs4java/opencl/CLContext.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ public CLProgram createProgram(Map<CLDevice, byte[]> binaries, String source) {
312312
//cl_queue queue;
313313
@Override
314314
protected void clear() {
315-
error(CL.clReleaseContext(getEntity()));
315+
error(CL.clReleaseContext(getEntityPeer()));
316316
}
317317

318318

Core/src/test/java/com/nativelibs4java/opencl/OverheadTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ public void compareVariousSetArgsPerformance() throws CLBuildException {
7979
kernel.setArg(4, (byte)1);
8080
kernel.setArg(5, 1.0f);
8181
}};
82+
/*
8283
Runnable setWithCLAPI = new Runnable() {
8384
private final OpenCLLibrary CL = new OpenCLLibrary();
8485
private final Pointer<?> tmp = allocateBytes(8);
@@ -91,6 +92,7 @@ public void run() {
9192
CL.clSetKernelArg(kernel.getEntity(), 5, 4L, tmp.setFloat(1));
9293
}
9394
};
95+
*/
9496
Runnable setWithRawCLAPI = new Runnable() {
9597
private final long aPeer = a.getEntityPeer();
9698
private final long bPeer = b.getEntityPeer();
@@ -113,15 +115,15 @@ public void run() {
113115
};
114116

115117
int nWarmup = 8000, nTest = 50000;
116-
time(null, nWarmup, setWithCLAPI, null);
118+
//time(null, nWarmup, setWithCLAPI, null);
117119
time(null, nWarmup, setWithSetArgs, null);
118120
time(null, nWarmup, setWithSpecializedSetArg, null);
119121
time(null, nWarmup, setWithRawCLAPI, null);
120122

121123
int nSamples = 10;
122124
double totSetArgs = 0, totCLSetKernelArg = 0, totSetArg = 0, totCLSetKernelArgRaw = 0;
123125
for (int i = 0; i < nSamples; i++) {
124-
totCLSetKernelArg += time("clSetKernelArg pointers", nTest, setWithCLAPI, null);
126+
//totCLSetKernelArg += time("clSetKernelArg pointers", nTest, setWithCLAPI, null);
125127
totSetArgs += time("CLKernel.setArgs", nTest, setWithSetArgs, null);
126128
totSetArg += time("CLKernel.setArg", nTest, setWithSpecializedSetArg, null);
127129
totCLSetKernelArgRaw += time("clSetKernelArg raw", nTest, setWithRawCLAPI, null);

0 commit comments

Comments
 (0)