Skip to content

Commit 5322faa

Browse files
briandorseybriandorsey
authored
chore(fixit): remove redundant region tags (GoogleCloudPlatform#9315)
Manually searched docs and confirmed no references remain. Only removed comments, no code changes. Removed these tags: run_broken_service_upgrade run_broken_service_problem run_broken_service run_pubsub_server run_pubsub_handler run_manual_logging run_imageproc_controller run_imageproc_handler_setup run_imageproc_handler_blur run_imageproc_handler_analyze These tags are referenced in docs at all, so removed both variations: run_manual_logging_dep cloudrun_manual_logging_dep run_manual_logging_jib cloudrun_manual_logging_jib
1 parent bf2cb62 commit 5322faa

File tree

7 files changed

+0
-30
lines changed

7 files changed

+0
-30
lines changed

‎run/hello-broken/src/main/java/com/example/cloudrun/App.java‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.example.cloudrun;
1818

1919
// [START cloudrun_broken_service]
20-
// [START run_broken_service]
2120
import static spark.Spark.get;
2221
import static spark.Spark.port;
2322

@@ -37,7 +36,6 @@ public static void main(String[] args) {
3736
(req, res) -> {
3837
logger.info("Hello: received request.");
3938
// [START cloudrun_broken_service_problem]
40-
// [START run_broken_service_problem]
4139
String name = System.getenv("NAME");
4240
if (name == null) {
4341
// Standard error logs do not appear in Stackdriver Error Reporting.
@@ -47,31 +45,25 @@ public static void main(String[] args) {
4745
res.status(500);
4846
return "Internal Server Error";
4947
}
50-
// [END run_broken_service_problem]
5148
// [END cloudrun_broken_service_problem]
5249
res.status(200);
5350
return String.format("Hello %s!", name);
5451
});
55-
// [END run_broken_service]
5652
// [END cloudrun_broken_service]
5753
get(
5854
"/improved",
5955
(req, res) -> {
6056
logger.info("Hello: received request.");
6157
// [START cloudrun_broken_service_upgrade]
62-
// [START run_broken_service_upgrade]
6358
String name = System.getenv().getOrDefault("NAME", "World");
6459
if (System.getenv("NAME") == null) {
6560
logger.warn(String.format("NAME not set, default to %s", name));
6661
}
67-
// [END run_broken_service_upgrade]
6862
// [END cloudrun_broken_service_upgrade]
6963
res.status(200);
7064
return String.format("Hello %s!", name);
7165
});
7266
// [START cloudrun_broken_service]
73-
// [START run_broken_service]
7467
}
7568
}
76-
// [END run_broken_service]
7769
// [END cloudrun_broken_service]

‎run/image-processing/src/main/java/com/example/cloudrun/ImageMagick.java‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.example.cloudrun;
1818

1919
// [START cloudrun_imageproc_handler_setup]
20-
// [START run_imageproc_handler_setup]
2120
import com.google.cloud.storage.Blob;
2221
import com.google.cloud.storage.BlobId;
2322
import com.google.cloud.storage.BlobInfo;
@@ -44,11 +43,9 @@ public class ImageMagick {
4443

4544
private static final String BLURRED_BUCKET_NAME = System.getenv("BLURRED_BUCKET_NAME");
4645
private static Storage storage = StorageOptions.getDefaultInstance().getService();
47-
// [END run_imageproc_handler_setup]
4846
// [END cloudrun_imageproc_handler_setup]
4947

5048
// [START cloudrun_imageproc_handler_analyze]
51-
// [START run_imageproc_handler_analyze]
5249
// Blurs uploaded images that are flagged as Adult or Violence.
5350
public static void blurOffensiveImages(JsonObject data) {
5451
String fileName = data.get("name").getAsString();
@@ -89,11 +86,9 @@ public static void blurOffensiveImages(JsonObject data) {
8986
System.out.println(String.format("Error with Vision API: %s", e.getMessage()));
9087
}
9188
}
92-
// [END run_imageproc_handler_analyze]
9389
// [END cloudrun_imageproc_handler_analyze]
9490

9591
// [START cloudrun_imageproc_handler_blur]
96-
// [START run_imageproc_handler_blur]
9792
// Blurs the file described by blobInfo using ImageMagick,
9893
// and uploads it to the blurred bucket.
9994
public static void blur(BlobInfo blobInfo) throws IOException {
@@ -138,5 +133,4 @@ public static void blur(BlobInfo blobInfo) throws IOException {
138133
Files.delete(upload);
139134
}
140135
}
141-
// [END run_imageproc_handler_blur]
142136
// [END cloudrun_imageproc_handler_blur]

‎run/image-processing/src/main/java/com/example/cloudrun/PubSubController.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.example.cloudrun;
1818

1919
// [START cloudrun_imageproc_controller]
20-
// [START run_imageproc_controller]
2120
import com.google.gson.JsonObject;
2221
import com.google.gson.JsonParser;
2322
import java.util.Base64;
@@ -70,5 +69,4 @@ public ResponseEntity<String> receiveMessage(@RequestBody Body body) {
7069
return new ResponseEntity<>(HttpStatus.OK);
7170
}
7271
}
73-
// [END run_imageproc_controller]
7472
// [END cloudrun_imageproc_controller]

‎run/logging-manual/pom.xml‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ limitations under the License.
3434
<artifactId>spark-core</artifactId>
3535
<version>2.9.4</version>
3636
</dependency>
37-
<!-- [START cloudrun_manual_logging_dep] -->
38-
<!-- [START run_manual_logging_dep] -->
3937
<dependency>
4038
<groupId>org.slf4j</groupId>
4139
<artifactId>slf4j-api</artifactId>
@@ -51,8 +49,6 @@ limitations under the License.
5149
<artifactId>logback-classic</artifactId>
5250
<version>1.4.14</version>
5351
</dependency>
54-
<!-- [END run_manual_logging_dep] -->
55-
<!-- [END cloudrun_manual_logging_dep] -->
5652
<dependency>
5753
<groupId>com.squareup.okhttp3</groupId>
5854
<artifactId>okhttp</artifactId>
@@ -68,8 +64,6 @@ limitations under the License.
6864

6965
<build>
7066
<plugins>
71-
<!-- [START cloudrun_manual_logging_jib] -->
72-
<!-- [START run_manual_logging_jib] -->
7367
<plugin>
7468
<groupId>com.google.cloud.tools</groupId>
7569
<artifactId>jib-maven-plugin</artifactId>
@@ -80,8 +74,6 @@ limitations under the License.
8074
</to>
8175
</configuration>
8276
</plugin>
83-
<!-- [END run_manual_logging_jib] -->
84-
<!-- [END cloudrun_manual_logging_jib] -->
8577
</plugins>
8678
</build>
8779
</project>

‎run/logging-manual/src/main/java/com/example/cloudrun/App.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ public static void main(String[] args) {
4141
"/",
4242
(req, res) -> {
4343
// [START cloudrun_manual_logging]
44-
// [START run_manual_logging]
4544
// Build structured log messages as an object.
4645
Object globalLogFields = null;
4746

@@ -64,7 +63,6 @@ public static void main(String[] args) {
6463
kv("component", "arbitrary-property"),
6564
kv("severity", "NOTICE"),
6665
globalLogFields);
67-
// [END run_manual_logging]
6866
// [END cloudrun_manual_logging]
6967
res.status(200);
7068
return "Hello Logger!";

‎run/pubsub/src/main/java/com/example/cloudrun/PubSubApplication.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.example.cloudrun;
1818

1919
// [START cloudrun_pubsub_server]
20-
// [START run_pubsub_server]
2120
import org.springframework.boot.SpringApplication;
2221
import org.springframework.boot.autoconfigure.SpringBootApplication;
2322

@@ -27,5 +26,4 @@ public static void main(String[] args) {
2726
SpringApplication.run(PubSubApplication.class, args);
2827
}
2928
}
30-
// [END run_pubsub_server]
3129
// [END cloudrun_pubsub_server]

‎run/pubsub/src/main/java/com/example/cloudrun/PubSubController.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.example.cloudrun;
1818

1919
// [START cloudrun_pubsub_handler]
20-
// [START run_pubsub_handler]
2120
import com.example.cloudrun.Body;
2221
import java.util.Base64;
2322
import org.apache.commons.lang3.StringUtils;
@@ -50,5 +49,4 @@ public ResponseEntity<String> receiveMessage(@RequestBody Body body) {
5049
return new ResponseEntity<>(msg, HttpStatus.OK);
5150
}
5251
}
53-
// [END run_pubsub_handler]
5452
// [END cloudrun_pubsub_handler]

0 commit comments

Comments
 (0)