ENH: perfomance: using clear() and empty() more faster for stl containers

uburuntu · uburuntu · commit f4ce49d88372 · 2017-06-02T22:38:00.000+04:00
diff --git a/lib/checkbufferoverrun.cpp b/lib/checkbufferoverrun.cpp
@@ -1645,7 +1645,7 @@ MathLib::biguint CheckBufferOverrun::countSprintfLength(const std::string &input
                 input_string_size += tempDigits;
 
             parameterLength = 0;
-            digits_string = "";
+            digits_string.clear();
             i_d_x_f_found = false;
             percentCharFound = false;
             handleNextParameter = false;
diff --git a/lib/checkstl.cpp b/lib/checkstl.cpp
@@ -610,7 +610,7 @@ void CheckStl::pushback()
                 } else {
                     vectorid = 0;
                 }
-                invalidIterator = "";
+                invalidIterator.clear();
             }
 
             // push_back on vector..
diff --git a/lib/checkunusedfunctions.cpp b/lib/checkunusedfunctions.cpp
@@ -176,7 +176,7 @@ void CheckUnusedFunctions::parseTokens(const Tokenizer &tokenizer, const char Fi
                     if (funcToken->str()==",") {
                         if (++index == argIndex)
                             break;
-                        value = "";
+                        value.clear();
                     } else
                         value += funcToken->str();
                     funcToken = funcToken->next();
diff --git a/lib/library.cpp b/lib/library.cpp
@@ -72,7 +72,7 @@ Library::Error Library::load(const char exename[], const char path[])
     if (error == tinyxml2::XML_ERROR_FILE_NOT_FOUND) {
         // failed to open file.. is there no extension?
         std::string fullfilename(path);
-        if (Path::getFilenameExtension(fullfilename) == "") {
+        if (Path::getFilenameExtension(fullfilename).empty()) {
             fullfilename += ".cfg";
             error = doc.LoadFile(fullfilename.c_str());
             if (error != tinyxml2::XML_ERROR_FILE_NOT_FOUND)
diff --git a/lib/path.cpp b/lib/path.cpp
@@ -84,7 +84,7 @@ std::string Path::simplifyPath(std::string originalPath)
         if (originalPath[i] == '/' || originalPath[i] == '\\') {
             if (subPath.length() > 0) {
                 pathParts.push_back(subPath);
-                subPath = "";
+                subPath.clear();
             }
 
             pathParts.push_back(std::string(1 , originalPath[i]));
diff --git a/lib/tokenize.cpp b/lib/tokenize.cpp
@@ -4782,7 +4782,7 @@ bool Tokenizer::simplifyConditions()
 
                         // It is inconclusive whether two unequal float representations are numerically equal
                         if (!eq && MathLib::isFloat(op1))
-                            cmp = "";
+                            cmp.clear();
                     }
 
                     if (cmp == "==")
@@ -4801,7 +4801,7 @@ bool Tokenizer::simplifyConditions()
                     else if (cmp == "<")
                         result = (op1 < op2);
                     else
-                        cmp = "";
+                        cmp.clear();
                 }
             } else {
                 // Compare boolean
@@ -4821,7 +4821,7 @@ bool Tokenizer::simplifyConditions()
                 else if (cmp == "<")
                     result = (op1 < op2);
                 else
-                    cmp = "";
+                    cmp.clear();
             }
 
             if (! cmp.empty()) {

Original file line number	Diff line number	Diff line change
`@@ -610,7 +610,7 @@ void CheckStl::pushback()`
`610`	`610`	`} else {`
`611`	`611`	`vectorid = 0;`
`612`	`612`	`}`
`613`		`- invalidIterator = "";`
	`613`	`+ invalidIterator.clear();`
`614`	`614`	`}`
`615`	`615`
`616`	`616`	`// push_back on vector..`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ std::string Path::simplifyPath(std::string originalPath)`
`84`	`84`	`if (originalPath[i] == '/' \|\| originalPath[i] == '\\') {`
`85`	`85`	`if (subPath.length() > 0) {`
`86`	`86`	`pathParts.push_back(subPath);`
`87`		`- subPath = "";`
	`87`	`+ subPath.clear();`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`pathParts.push_back(std::string(1 , originalPath[i]));`